From 6ffac8810beae8220aecf19211641eb95fb68e7c Mon Sep 17 00:00:00 2001 From: catlog22 Date: Sun, 28 Dec 2025 22:44:47 +0800 Subject: [PATCH] test(cli-command): add unit tests for CLI command executor Solution-ID: SOL-1735386000001 Issue-ID: ISS-1766921318981-15 Task-ID: T1 --- ccw/tests/cli-command.test.ts | 232 ++++++++++++++++++++++++++++++++++ package.json | 2 +- 2 files changed, 233 insertions(+), 1 deletion(-) create mode 100644 ccw/tests/cli-command.test.ts diff --git a/ccw/tests/cli-command.test.ts b/ccw/tests/cli-command.test.ts new file mode 100644 index 00000000..8bd3cb25 --- /dev/null +++ b/ccw/tests/cli-command.test.ts @@ -0,0 +1,232 @@ +/** + * Unit tests for CLI command module (ccw cli) + * + * Notes: + * - Targets the runtime implementation shipped in `ccw/dist`. + * - Uses Node's built-in test runner (node:test). + * - Mocks external tool execution and dashboard notification. + */ + +import { after, afterEach, before, describe, it, mock } from 'node:test'; +import assert from 'node:assert/strict'; +import http from 'node:http'; +import { mkdtempSync, rmSync } from 'node:fs'; +import { tmpdir } from 'node:os'; +import { join } from 'node:path'; + +const TEST_CCW_HOME = mkdtempSync(join(tmpdir(), 'ccw-cli-command-')); +process.env.CCW_DATA_DIR = TEST_CCW_HOME; + +const cliCommandPath = new URL('../dist/commands/cli.js', import.meta.url).href; +const cliExecutorPath = new URL('../dist/tools/cli-executor.js', import.meta.url).href; +const historyStorePath = new URL('../dist/tools/cli-history-store.js', import.meta.url).href; + +function stubHttpRequest(): void { + mock.method(http, 'request', () => { + const req: { + on: (event: string, handler: (arg?: any) => void) => typeof req; + write: (data: any) => void; + end: () => void; + destroy: () => void; + } = { + on(event, handler) { + if (event === 'socket') { + handler({ unref() {} }); + } + return req; + }, + write() {}, + end() {}, + destroy() {}, + }; + return req as any; + }); +} + +describe('cli command module', async () => { + // eslint-disable-next-line @typescript-eslint/no-explicit-any + let cliModule: any; + // eslint-disable-next-line @typescript-eslint/no-explicit-any + let cliExecutorModule: any; + // eslint-disable-next-line @typescript-eslint/no-explicit-any + let historyStoreModule: any; + + before(async () => { + cliModule = await import(cliCommandPath); + cliExecutorModule = await import(cliExecutorPath); + historyStoreModule = await import(historyStorePath); + }); + + afterEach(() => { + mock.restoreAll(); + }); + + after(() => { + try { + historyStoreModule?.closeAllStores?.(); + } catch { + // ignore + } + rmSync(TEST_CCW_HOME, { recursive: true, force: true }); + }); + + it('executes tool (gemini/qwen/codex) and passes parameters to executor', async () => { + stubHttpRequest(); + mock.method(console, 'log', () => {}); + mock.method(console, 'error', () => {}); + + const calls: any[] = []; + mock.method(cliExecutorModule.cliExecutorTool, 'execute', async (params: any) => { + calls.push(params); + return { + success: true, + stdout: 'ok', + stderr: '', + execution: { id: 'EXEC-1', duration_ms: 12, status: 'success' }, + conversation: { turn_count: 1, total_duration_ms: 12 }, + }; + }); + + const exitCodes: Array = []; + mock.method(process as any, 'exit', (code?: number) => { + exitCodes.push(code); + }); + + for (const tool of ['gemini', 'qwen', 'codex']) { + await cliModule.cliCommand('exec', [], { prompt: 'Hello', tool }); + } + + // `ccw/dist` schedules process exit with a small timeout for "fire-and-forget" dashboard notification. + await new Promise((resolve) => setTimeout(resolve, 150)); + + assert.deepEqual( + calls.map((c) => c.tool), + ['gemini', 'qwen', 'codex'], + ); + for (const call of calls) { + assert.equal(call.prompt, 'Hello'); + assert.equal(call.mode, 'analysis'); + assert.equal(call.stream, false); + assert.equal(call.timeout, 300000); + } + assert.deepEqual(exitCodes, [0, 0, 0]); + }); + + it('supports resume with conversation ID and latest (no prompt required)', async () => { + stubHttpRequest(); + mock.method(console, 'log', () => {}); + mock.method(console, 'error', () => {}); + + const resumes: any[] = []; + mock.method(cliExecutorModule.cliExecutorTool, 'execute', async (params: any) => { + resumes.push(params.resume); + return { + success: true, + stdout: '', + stderr: '', + execution: { id: 'EXEC-R', duration_ms: 1, status: 'success' }, + conversation: { turn_count: 2, total_duration_ms: 1 }, + }; + }); + + const exitCodes: Array = []; + mock.method(process as any, 'exit', (code?: number) => { + exitCodes.push(code); + }); + + await cliModule.cliCommand('exec', [], { tool: 'gemini', resume: true }); + await cliModule.cliCommand('exec', [], { tool: 'gemini', resume: 'CONV-123' }); + + await new Promise((resolve) => setTimeout(resolve, 150)); + + assert.deepEqual(resumes, [true, 'CONV-123']); + assert.deepEqual(exitCodes, [0, 0]); + }); + + it('validates prompt requirement when not resuming', async () => { + stubHttpRequest(); + + class ExitError extends Error { + code?: number; + + constructor(code?: number) { + super(`process.exit(${code ?? 'undefined'})`); + this.code = code; + } + } + + let executed = false; + mock.method(cliExecutorModule.cliExecutorTool, 'execute', async () => { + executed = true; + return { + success: true, + stdout: '', + stderr: '', + execution: { id: 'EXEC-NEVER', duration_ms: 1, status: 'success' }, + conversation: { turn_count: 1, total_duration_ms: 1 }, + }; + }); + + // Use a non-subcommand-looking value so it won't be treated as a positional prompt. + // `resume: false` forces execAction path without satisfying "resuming" condition. + mock.method(process as any, 'exit', (code?: number) => { + throw new ExitError(code); + }); + + await assert.rejects( + cliModule.cliCommand('-ignored', [], { tool: 'gemini', resume: false }), + (err: any) => err instanceof ExitError && err.code === 1, + ); + + assert.equal(executed, false); + }); + + it('prints history and retrieves conversation detail from SQLite store', async () => { + stubHttpRequest(); + + const logs: string[] = []; + mock.method(console, 'log', (...args: any[]) => { + logs.push(args.map(String).join(' ')); + }); + mock.method(console, 'error', (...args: any[]) => { + logs.push(args.map(String).join(' ')); + }); + + const store = historyStoreModule.getHistoryStore(process.cwd()); + store.saveConversation({ + id: 'CONV-CLI-1', + created_at: new Date('2025-01-01T00:00:00.000Z').toISOString(), + updated_at: new Date('2025-01-01T00:00:01.000Z').toISOString(), + tool: 'gemini', + model: 'default', + mode: 'analysis', + category: 'user', + total_duration_ms: 123, + turn_count: 1, + latest_status: 'success', + turns: [ + { + turn: 1, + timestamp: new Date('2025-01-01T00:00:00.000Z').toISOString(), + prompt: 'Test prompt', + duration_ms: 123, + status: 'success', + exit_code: 0, + output: { stdout: 'OK', stderr: '', truncated: false, cached: false }, + }, + ], + }); + + await cliModule.cliCommand('history', [], { limit: '20' }); + assert.ok(logs.some((l) => l.includes('CONV-CLI-1'))); + + // Ensure cli-executor SQLite module is initialized for sync detail retrieval + await cliExecutorModule.getExecutionHistoryAsync(process.cwd(), { limit: 1 }); + + logs.length = 0; + await cliModule.cliCommand('detail', ['CONV-CLI-1'], {}); + assert.ok(logs.some((l) => l.includes('Conversation Detail'))); + assert.ok(logs.some((l) => l.includes('CONV-CLI-1'))); + assert.ok(logs.some((l) => l.includes('Test prompt'))); + }); +}); diff --git a/package.json b/package.json index 247bdcc4..a038a5a0 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "scripts": { "build": "tsc -p ccw/tsconfig.json", "start": "node ccw/bin/ccw.js", - "test": "node --test ccw/tests/*.test.js", + "test": "node --experimental-strip-types --test ccw/tests/*.test.js", "prepublishOnly": "npm run build && echo 'Ready to publish @dyw/claude-code-workflow'" }, "keywords": [