catlog22/Claude-Code-Workflow
1
0
Fork 0
mirror of https://github.com/catlog22/Claude-Code-Workflow.git synced 2026-02-14 02:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(skills): enhance moveDirectory function with rollback on failure and update config handling

Browse Source
This commit is contained in:
catlog22
2026-01-28 00:50:24 +08:00
parent 7a40f16235
commit af05874510
2 changed files with 43 additions and 562 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
ccw/src/core/routes/skills-routes.ts
View File

@@ -94,7 +94,7 @@ function saveDisabledSkillsConfig(location: SkillLocation, projectPath: string,
}
/**
* Move directory with fallback to copy-delete
* Move directory with fallback to copy-delete and rollback on failure
*/
function moveDirectory(source: string, target: string): void {
try {
@@ -105,7 +105,17 @@ function moveDirectory(source: string, target: string): void {
// If rename fails (cross-filesystem, permission issues), fallback to copy-delete
if (err.code === 'EXDEV' || err.code === 'EPERM' || err.code === 'EBUSY') {
cpSync(source, target, { recursive: true, force: true });
rmSync(source, { recursive: true, force: true });
try {
rmSync(source, { recursive: true, force: true });
} catch (rmError) {
// Rollback: remove the copied target directory to avoid duplicates
try {
rmSync(target, { recursive: true, force: true });
} catch {
// Ignore rollback errors
}
throw new Error(`Failed to remove source directory after copy: ${(rmError as Error).message}`);
}
} else {
throw error;
}
@@ -161,13 +171,23 @@ async function disableSkill(
// Move skill to disabled directory
moveDirectory(sourceDir, targetDir);
// Update config
const config = loadDisabledSkillsConfig(location, projectPath);
config.skills[skillName] = {
disabledAt: new Date().toISOString(),
reason
};
saveDisabledSkillsConfig(location, projectPath, config);
// Update config with rollback on failure
try {
const config = loadDisabledSkillsConfig(location, projectPath);
config.skills[skillName] = {
disabledAt: new Date().toISOString(),
reason
};
saveDisabledSkillsConfig(location, projectPath, config);
} catch (configError) {
// Rollback: move the skill back to original location
try {
moveDirectory(targetDir, sourceDir);
} catch {
// Ignore rollback errors - skill is in disabled directory but not in config
}
throw new Error(`Failed to update config: ${(configError as Error).message}`);
}
return { success: true, message: 'Skill disabled', skillName, location };
} catch (error) {
@@ -223,10 +243,20 @@ async function enableSkill(
// Move skill back to skills directory
moveDirectory(sourceDir, targetDir);
// Update config
const config = loadDisabledSkillsConfig(location, projectPath);
delete config.skills[skillName];
saveDisabledSkillsConfig(location, projectPath, config);
// Update config with rollback on failure
try {
const config = loadDisabledSkillsConfig(location, projectPath);
delete config.skills[skillName];
saveDisabledSkillsConfig(location, projectPath, config);
} catch (configError) {
// Rollback: move the skill back to disabled directory
try {
moveDirectory(targetDir, sourceDir);
} catch {
// Ignore rollback errors - skill is in skills directory but still in config
}
throw new Error(`Failed to update config: ${(configError as Error).message}`);
}
return { success: true, message: 'Skill enabled', skillName, location };
} catch (error) {