catlog22/Claude-Code-Workflow
1
0
Fork 0
mirror of https://github.com/catlog22/Claude-Code-Workflow.git synced 2026-02-10 02:24:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat: Add interactive pre-flight checklists for ccw-loop and workflow-plan, including validation and task transformation steps

Browse Source 
- Implemented `prep-loop.md` for ccw-loop, detailing source discovery, validation, task transformation, and auto-loop configuration.
- Created `prep-plan.md` for workflow planning, covering environment checks, task quality assessment, execution preferences, and final confirmation.
- Defined schemas and integration points for `prep-package.json` in both ccw-loop and workflow-plan skills, ensuring proper validation and task handling.
- Added error handling mechanisms for various scenarios during the preparation phases.
This commit is contained in:
catlog22
2026-02-09 15:02:38 +08:00
parent ef7382ecf5
commit c62d26183b
25 changed files with 1596 additions and 2896 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
ccw/src/commands/stop.ts
View File

@@ -16,11 +16,25 @@ interface StopOptions {
*/
async function findProcessOnPort(port: number): Promise<string | null> {
try {
const { stdout } = await execAsync(`netstat -ano | findstr :${port} | findstr LISTENING`);
const lines = stdout.trim().split('\n');
if (lines.length > 0) {
const parts = lines[0].trim().split(/\s+/);
return parts[parts.length - 1]; // PID is the last column
// Avoid filtering on the localized state column (e.g. not always "LISTENING").
const { stdout } = await execAsync(`netstat -ano | findstr :${port}`);
const lines = stdout.trim().split(/\r?\n/).map((l) => l.trim()).filter(Boolean);
for (const line of lines) {
// Typical format:
// TCP 0.0.0.0:3457 0.0.0.0:0 LISTENING 31736
// TCP [::]:3457 [::]:0 LISTENING 31736
const parts = line.split(/\s+/);
if (parts.length < 4) continue;
const proto = parts[0]?.toUpperCase();
const localAddress = parts[1] || '';
const pidCandidate = parts[parts.length - 1] || '';
if (proto !== 'TCP') continue;
if (!localAddress.endsWith(`:${port}`)) continue;
if (!/^\d+$/.test(pidCandidate)) continue;
return pidCandidate; // PID is the last column
}
} catch {
// No process found
@@ -28,20 +42,62 @@ async function findProcessOnPort(port: number): Promise<string | null> {
return null;
}
async function getProcessCommandLine(pid: string): Promise<string | null> {
if (!/^\d+$/.test(pid)) return null;
try {
const probeCommand =
process.platform === 'win32'
? `powershell -NoProfile -Command "(Get-CimInstance Win32_Process -Filter 'ProcessId=${pid}').CommandLine"`
: `ps -p ${pid} -o command=`;
const { stdout } = await execAsync(probeCommand);
const commandLine = stdout.trim();
return commandLine.length > 0 ? commandLine : null;
} catch {
return null;
}
}
function isLikelyViteCommandLine(commandLine: string, port: number): boolean {
const lower = commandLine.toLowerCase();
if (!lower.includes('vite')) return false;
const portStr = String(port);
return (
lower.includes(`--port ${portStr}`) ||
lower.includes(`--port=${portStr}`) ||
// Some npm wrappers pass through the port in a slightly different shape.
lower.includes(`port ${portStr}`)
);
}
/**
* Kill process by PID (Windows)
* @param {string} pid - Process ID
* @returns {Promise<boolean>} Success status
*/
async function killProcess(pid: string): Promise<boolean> {
if (!/^\d+$/.test(pid)) return false;
try {
// Use PowerShell to avoid Git Bash path expansion issues with /PID
await execAsync(`powershell -Command "Stop-Process -Id ${pid} -Force -ErrorAction Stop"`);
// Prefer taskkill to terminate the entire process tree on Windows (npm/cmd wrappers can orphan children).
if (process.platform === 'win32') {
await execAsync(`cmd /c "taskkill /PID ${pid} /T /F"`);
return true;
}
// Best-effort on non-Windows platforms (mockable via child_process.exec in tests).
await execAsync(`kill -TERM ${pid}`);
return true;
} catch {
// Fallback to taskkill via cmd
try {
await execAsync(`cmd /c "taskkill /PID ${pid} /F"`);
if (process.platform === 'win32') {
await execAsync(`powershell -NoProfile -Command "Stop-Process -Id ${pid} -Force -ErrorAction Stop"`);
return true;
}
await execAsync(`kill -KILL ${pid}`);
return true;
} catch {
return false;
@@ -105,6 +161,7 @@ export async function stopCommand(options: StopOptions): Promise<void> {
await cleanupReactFrontend(reactPort);
console.log(chalk.green.bold('\n Server stopped successfully!\n'));
process.exit(0);
return;
}
// Best-effort verify shutdown (may still succeed even if shutdown endpoint didn't return ok)
@@ -116,6 +173,7 @@ export async function stopCommand(options: StopOptions): Promise<void> {
await cleanupReactFrontend(reactPort);
console.log(chalk.green.bold('\n Server stopped successfully!\n'));
process.exit(0);
return;
}
const statusHint = shutdownResponse ? `HTTP ${shutdownResponse.status}` : 'no response';
@@ -132,7 +190,11 @@ export async function stopCommand(options: StopOptions): Promise<void> {
const reactPid = await findProcessOnPort(reactPort);
if (reactPid) {
console.log(chalk.yellow(` React frontend still running on port ${reactPort} (PID: ${reactPid})`));
if (force) {
const commandLine = await getProcessCommandLine(reactPid);
const isLikelyVite = commandLine ? isLikelyViteCommandLine(commandLine, reactPort) : false;
if (force || isLikelyVite) {
console.log(chalk.cyan(' Cleaning up React frontend...'));
const killed = await killProcess(reactPid);
if (killed) {
@@ -141,10 +203,12 @@ export async function stopCommand(options: StopOptions): Promise<void> {
console.log(chalk.red(' Failed to stop React frontend.\n'));
}
} else {
console.log(chalk.gray(`\n Use --force to clean it up:\n ccw stop --force\n`));
console.log(chalk.gray(`\n React process does not look like Vite on port ${reactPort}.`));
console.log(chalk.gray(` Use --force to clean it up:\n ccw stop --force\n`));
}
}
process.exit(0);
return;
}
// Port is in use by another process
@@ -174,9 +238,11 @@ export async function stopCommand(options: StopOptions): Promise<void> {
console.log(chalk.green.bold('\n All processes stopped successfully!\n'));
process.exit(0);
return;
} else {
console.log(chalk.red('\n Failed to kill process. Try running as administrator.\n'));
process.exit(1);
return;
}
} else {
// Also check React frontend port
@@ -188,11 +254,13 @@ export async function stopCommand(options: StopOptions): Promise<void> {
console.log(chalk.gray(`\n This is not a CCW server. Use --force to kill it:`));
console.log(chalk.white(` ccw stop --force\n`));
process.exit(0);
return;
}
} catch (err) {
const error = err as Error;
console.error(chalk.red(`\n Error: ${error.message}\n`));
process.exit(1);
return;
}
}

62
ccw/tests/stop-command.test.ts
View File

@@ -21,17 +21,43 @@ describe('stop command module', async () => {
const childProcess = require('child_process');
const originalExec = childProcess.exec;
const execCalls: string[] = [];
const netstatByPort = new Map<number, string>();
const commandLineByPid = new Map<string, string>();
before(async () => {
// Patch child_process.exec BEFORE importing stop module (it captures exec at module init).
childProcess.exec = (command: string, cb: any) => {
execCalls.push(command);
if (/^netstat -ano/i.test(command)) {
const stdout = 'TCP 0.0.0.0:56792 0.0.0.0:0 LISTENING 4242\r\n';
const portMatch = command.match(/findstr\s+:([0-9]+)/i);
const port = portMatch ? Number(portMatch[1]) : NaN;
const stdout = Number.isFinite(port) ? (netstatByPort.get(port) ?? '') : '';
cb(null, stdout, '');
return {} as any;
}
if (/^taskkill /i.test(command)) {
if (/taskkill\b/i.test(command)) {
cb(null, '', '');
return {} as any;
}
if (/^powershell\b/i.test(command) && /Get-CimInstance\s+Win32_Process/i.test(command)) {
const pidMatch = command.match(/ProcessId=([0-9]+)/i);
const pid = pidMatch ? pidMatch[1] : '';
const stdout = commandLineByPid.get(pid) ?? '';
cb(null, stdout, '');
return {} as any;
}
if (/^ps\s+-p\s+/i.test(command)) {
const pidMatch = command.match(/^ps\s+-p\s+([0-9]+)/i);
const pid = pidMatch ? pidMatch[1] : '';
const stdout = commandLineByPid.get(pid) ?? '';
cb(null, stdout, '');
return {} as any;
}
if (/^powershell\b/i.test(command) && /Stop-Process\s+-Id/i.test(command)) {
cb(null, '', '');
return {} as any;
}
if (/^kill\s+-/i.test(command)) {
cb(null, '', '');
return {} as any;
}
@@ -44,6 +70,8 @@ describe('stop command module', async () => {
afterEach(() => {
execCalls.length = 0;
netstatByPort.clear();
commandLineByPid.clear();
mock.restoreAll();
});
@@ -84,9 +112,10 @@ describe('stop command module', async () => {
// No server responding, fall back to netstat/taskkill
mock.method(globalThis as any, 'fetch', async () => null);
netstatByPort.set(56792, 'TCP 0.0.0.0:56792 0.0.0.0:0 LISTENING 4242\r\n');
await stopModule.stopCommand({ port: 56792, force: true });
assert.ok(execCalls.some((c) => /^taskkill /i.test(c)));
assert.ok(execCalls.some((c) => /taskkill\b/i.test(c) || /Stop-Process\b/i.test(c) || /^kill\s+-/i.test(c)));
assert.ok(exitCodes.includes(0));
assert.ok(!exitCodes.includes(1));
});
@@ -100,10 +129,35 @@ describe('stop command module', async () => {
});
mock.method(globalThis as any, 'fetch', async () => null);
netstatByPort.set(56792, 'TCP 0.0.0.0:56792 0.0.0.0:0 LISTENING 4242\r\n');
await stopModule.stopCommand({ port: 56792, force: false });
assert.ok(execCalls.some((c) => /^netstat -ano/i.test(c)));
assert.ok(!execCalls.some((c) => /^taskkill /i.test(c)));
assert.ok(!execCalls.some((c) => /taskkill\b/i.test(c) || /Stop-Process\b/i.test(c) || /^kill\s+-/i.test(c)));
assert.ok(exitCodes.includes(0));
assert.ok(!exitCodes.includes(1));
});
it('auto-cleans Vite on react port when main server is not running (no --force)', async () => {
mock.method(console, 'log', () => {});
mock.method(console, 'error', () => {});
const exitCodes: Array<number | undefined> = [];
mock.method(process as any, 'exit', (code?: number) => {
exitCodes.push(code);
});
// No server responding, main port free, react port occupied by Vite.
mock.method(globalThis as any, 'fetch', async () => null);
netstatByPort.set(56792, '');
netstatByPort.set(56793, 'TCP 0.0.0.0:56793 0.0.0.0:0 LISTENING 4242\r\n');
commandLineByPid.set('4242', 'cmd.exe /d /s /c vite --port 56793 --strictPort\r\n');
await stopModule.stopCommand({ port: 56792, force: false });
assert.ok(execCalls.some((c) =>
(/^powershell\b/i.test(c) && /Get-CimInstance\s+Win32_Process/i.test(c)) ||
/^ps\s+-p\s+/i.test(c)
));
assert.ok(execCalls.some((c) => /taskkill\b/i.test(c) || /Stop-Process\b/i.test(c) || /^kill\s+-/i.test(c)));
assert.ok(exitCodes.includes(0));
assert.ok(!exitCodes.includes(1));
});