feat: Implement phases 6 to 9 of the review cycle fix process, including discovery, batching, parallel planning, execution, and completion

- Added Phase 6: Fix Discovery & Batching with intelligent grouping and batching of findings. - Added Phase 7: Fix Parallel Planning to launch planning agents for concurrent analysis and aggregation of partial plans. - Added Phase 8: Fix Execution for stage-based execution of fixes with conservative test verification. - Added Phase 9: Fix Completion to aggregate results, generate summary reports, and handle session completion. - Introduced new frontend components: ResizeHandle for draggable resizing of sidebar panels and useResizablePanel hook for managing panel sizes with localStorage persistence. - Added PowerShell script for checking TypeScript errors in source code, excluding test files.
2026-02-14 02:42:04 +08:00 · 2026-02-07 19:28:33 +08:00
parent ba5f4eba84
commit d43696d756
90 changed files with 8462 additions and 616 deletions
--- a/.codex/skills/review-cycle/phases/09-fix-completion.md
+++ b/.codex/skills/review-cycle/phases/09-fix-completion.md
@@ -0,0 +1,141 @@
+# Phase 9: Fix Completion
+
+> Source: `commands/workflow/review-cycle-fix.md` Phase 4 + Phase 5
+
+## Overview
+Aggregate fix results, generate summary report, update history, and optionally complete workflow session.
+
+## Phase 4: Completion & Aggregation (Orchestrator)
+
+- Collect final status from all fix-progress-{N}.json files
+- Generate fix-summary.md with timeline and results
+- Update fix-history.json with new session entry
+- Remove active-fix-session.json
+- Progress tracking: Mark all phases done
+- Output summary to user
+
+## Phase 5: Session Completion (Orchestrator)
+
+- If all findings fixed successfully (no failures):
+  - Prompt user: "All fixes complete. Complete workflow session? [Y/n]"
+  - If confirmed: Archive session with lessons learned
+- If partial success (some failures):
+  - Output: "Some findings failed. Review fix-summary.md before completing session."
+  - Do NOT auto-complete session
+
+## Error Handling
+
+### Batching Failures (Phase 1.5)
+
+- Invalid findings data -> Abort with error message
+- Empty batches after grouping -> Warn and skip empty batches
+
+### Planning Failures (Phase 2)
+
+- Planning agent timeout -> Mark batch as failed, continue with other batches
+- Partial plan missing -> Skip batch, warn user
+- Agent crash -> Collect available partial plans, proceed with aggregation
+- All agents fail -> Abort entire fix session with error
+- Aggregation conflicts -> Apply conflict resolution (serialize conflicting groups)
+
+### Execution Failures (Phase 3)
+
+- Agent crash -> Mark group as failed, continue with other groups
+- Test command not found -> Skip test verification, warn user
+- Git operations fail -> Abort with error, preserve state
+
+### Rollback Scenarios
+
+- Test failure after fix -> Automatic `git checkout` rollback
+- Max iterations reached -> Leave file unchanged, mark as failed
+- Unrecoverable error -> Rollback entire group, save checkpoint
+
+## Progress Tracking Structures
+
+### Initialization (after Phase 1.5 batching)
+
+```
+Phase 1: Discovery & Initialization           → completed
+Phase 1.5: Intelligent Batching               → completed
+Phase 2: Parallel Planning                     → in_progress
+  → Batch 1: 4 findings (auth.ts:security)    → pending
+  → Batch 2: 3 findings (query.ts:security)   → pending
+  → Batch 3: 2 findings (config.ts:quality)   → pending
+Phase 3: Execution                             → pending
+Phase 4: Completion                            → pending
+```
+
+### During Planning (parallel agents running)
+
+```
+Phase 1: Discovery & Initialization           → completed
+Phase 1.5: Intelligent Batching               → completed
+Phase 2: Parallel Planning                     → in_progress
+  → Batch 1: 4 findings (auth.ts:security)    → completed
+  → Batch 2: 3 findings (query.ts:security)   → in_progress
+  → Batch 3: 2 findings (config.ts:quality)   → in_progress
+Phase 3: Execution                             → pending
+Phase 4: Completion                            → pending
+```
+
+### During Execution
+
+```
+Phase 1: Discovery & Initialization                → completed
+Phase 1.5: Intelligent Batching                    → completed
+Phase 2: Parallel Planning (3 batches → 5 groups)  → completed
+Phase 3: Execution                                  → in_progress
+  → Stage 1: Parallel execution (3 groups)          → completed
+    • Group G1: Auth validation (2 findings)        → completed
+    • Group G2: Query security (3 findings)         → completed
+    • Group G3: Config quality (1 finding)          → completed
+  → Stage 2: Serial execution (1 group)             → in_progress
+    • Group G4: Dependent fixes (2 findings)        → in_progress
+Phase 4: Completion                                 → pending
+```
+
+### Update Rules
+
+- Add batch items dynamically during Phase 1.5
+- Mark batch items completed as parallel agents return results
+- Add stage/group items dynamically after Phase 2 plan aggregation
+- Mark completed immediately after each group finishes
+- Update parent phase status when all child items complete
+
+## Post-Completion Expansion
+
+After completion, ask user whether to expand into issues (test/enhance/refactor/doc). For selected items, create structured issues with summary and dimension context.
+
+## Best Practices
+
+1. **Leverage Parallel Planning**: For 10+ findings, parallel batching significantly reduces planning time
+2. **Tune Batch Size**: Use `--batch-size` to control granularity (smaller batches = more parallelism, larger = better grouping context)
+3. **Conservative Approach**: Test verification is mandatory - no fixes kept without passing tests
+4. **Parallel Efficiency**: MAX_PARALLEL=10 for planning agents, 3 concurrent execution agents per stage
+5. **Resume Support**: Fix sessions can resume from checkpoints after interruption
+6. **Manual Review**: Always review failed fixes manually - may require architectural changes
+7. **Incremental Fixing**: Start with small batches (5-10 findings) before large-scale fixes
+
+## Related Commands
+
+### View Fix Progress
+Use `ccw view` to open the workflow dashboard in browser:
+
+```bash
+ccw view
+```
+
+### Re-run Fix Pipeline
+```
+review-cycle --fix ...
+```
+
+## Output
+
+- Files: fix-summary.md, fix-history.json
+- State: active-fix-session.json removed
+- Optional: workflow session completed and archived
+
+## Completion
+
+Review Cycle fix pipeline complete. Review fix-summary.md for results.