mirror of
https://github.com/catlog22/Claude-Code-Workflow.git
synced 2026-02-05 01:50:27 +08:00
* feat(security): Secure dashboard server by default ## Solution Summary - Solution-ID: SOL-DSC-002-1 - Issue-ID: DSC-002 ## Tasks Completed - [T1] JWT token manager (24h expiry, persisted secret/token) - [T2] API auth middleware + localhost token endpoint - [T3] Default bind 127.0.0.1, add --host with warning - [T4] Localhost-only CORS with credentials + Vary - [T5] SECURITY.md documentation + README link ## Verification - npm run build - npm test -- ccw/tests/token-manager.test.ts ccw/tests/middleware.test.ts ccw/tests/server-auth.integration.test.ts ccw/tests/server.test.ts ccw/tests/cors.test.ts * fix(security): Prevent command injection in Windows spawn() ## Solution Summary - **Solution-ID**: SOL-DSC-001-1 - **Issue-ID**: DSC-001 - **Risk/Impact/Complexity**: high/high/medium ## Tasks Completed - [T1] Create Windows shell escape utility - [T2] Escape cli-executor spawn() args on Windows - [T3] Add command injection regression tests ## Files Modified - ccw/src/utils/shell-escape.ts - ccw/src/tools/cli-executor.ts - ccw/tests/shell-escape.test.ts - ccw/tests/security/command-injection.test.ts ## Verification - npm run build - npm test -- ccw/tests/shell-escape.test.ts ccw/tests/security/command-injection.test.ts * fix(security): Harden path validation (DSC-005) ## Solution Summary - Solution-ID: SOL-DSC-005-1 - Issue-ID: DSC-005 ## Tasks Completed - T1: Refactor path validation to pre-resolution checking - T2: Implement allowlist-based path validation - T3: Add path validation to API routes - T4: Add path security regression tests ## Files Modified - ccw/src/utils/path-resolver.ts - ccw/src/utils/path-validator.ts - ccw/src/core/routes/graph-routes.ts - ccw/src/core/routes/files-routes.ts - ccw/src/core/routes/skills-routes.ts - ccw/tests/path-resolver.test.ts - ccw/tests/graph-routes.test.ts - ccw/tests/files-routes.test.ts - ccw/tests/skills-routes.test.ts - ccw/tests/security/path-traversal.test.ts ## Verification - npm run build - npm test -- path-resolver.test.ts - npm test -- path-validator.test.ts - npm test -- graph-routes.test.ts - npm test -- files-routes.test.ts - npm test -- skills-routes.test.ts - npm test -- ccw/tests/security/path-traversal.test.ts * fix(security): Prevent credential leakage (DSC-004) ## Solution Summary - Solution-ID: SOL-DSC-004-1 - Issue-ID: DSC-004 ## Tasks Completed - T1: Create credential handling security tests - T2: Add log sanitization tests - T3: Add env var leakage prevention tests - T4: Add secure storage tests ## Files Modified - ccw/src/config/litellm-api-config-manager.ts - ccw/src/core/routes/litellm-api-routes.ts - ccw/tests/security/credential-handling.test.ts ## Verification - npm run build - node --experimental-strip-types --test ccw/tests/security/credential-handling.test.ts * test(ranking): expand normalize_weights edge case coverage (ISS-1766920108814-0) ## Solution Summary - Solution-ID: SOL-20251228113607 - Issue-ID: ISS-1766920108814-0 ## Tasks Completed - T1: Fix NaN and invalid total handling in normalize_weights - T2: Add unit tests for NaN edge cases in normalize_weights ## Files Modified - codex-lens/tests/test_rrf_fusion.py ## Verification - python -m pytest codex-lens/tests/test_rrf_fusion.py::TestNormalizeBM25Score -v - python -m pytest codex-lens/tests/test_rrf_fusion.py -v -k normalize - python -m pytest codex-lens/tests/test_rrf_fusion.py::TestReciprocalRankFusion::test_weight_normalization codex-lens/tests/test_cli_hybrid_search.py::TestCLIHybridSearch::test_weights_normalization -v * feat(security): Add CSRF protection and tighten CORS (DSC-006) ## Solution Summary - Solution-ID: SOL-DSC-006-1 - Issue-ID: DSC-006 - Risk/Impact/Complexity: high/high/medium ## Tasks Completed - T1: Create CSRF token generation system - T2: Add CSRF token endpoints - T3: Implement CSRF validation middleware - T4: Restrict CORS to trusted origins - T5: Add CSRF security tests ## Files Modified - ccw/src/core/auth/csrf-manager.ts - ccw/src/core/auth/csrf-middleware.ts - ccw/src/core/routes/auth-routes.ts - ccw/src/core/server.ts - ccw/tests/csrf-manager.test.ts - ccw/tests/auth-routes.test.ts - ccw/tests/csrf-middleware.test.ts - ccw/tests/security/csrf.test.ts ## Verification - npm run build - node --experimental-strip-types --test ccw/tests/csrf-manager.test.ts - node --experimental-strip-types --test ccw/tests/auth-routes.test.ts - node --experimental-strip-types --test ccw/tests/csrf-middleware.test.ts - node --experimental-strip-types --test ccw/tests/cors.test.ts - node --experimental-strip-types --test ccw/tests/security/csrf.test.ts * fix(cli-executor): prevent stale SIGKILL timeouts ## Solution Summary - Solution-ID: SOL-DSC-007-1 - Issue-ID: DSC-007 - Risk/Impact/Complexity: low/low/low ## Tasks Completed - [T1] Store timeout handle in killCurrentCliProcess ## Files Modified - ccw/src/tools/cli-executor.ts - ccw/tests/cli-executor-kill.test.ts ## Verification - node --experimental-strip-types --test ccw/tests/cli-executor-kill.test.ts * fix(cli-executor): enhance merge validation guards ## Solution Summary - Solution-ID: SOL-DSC-008-1 - Issue-ID: DSC-008 - Risk/Impact/Complexity: low/low/low ## Tasks Completed - [T1] Enhance sourceConversations array validation ## Files Modified - ccw/src/tools/cli-executor.ts - ccw/tests/cli-executor-merge-validation.test.ts ## Verification - node --experimental-strip-types --test ccw/tests/cli-executor-merge-validation.test.ts * refactor(core): remove @ts-nocheck from core routes ## Solution Summary - Solution-ID: SOL-DSC-003-1 - Issue-ID: DSC-003 - Queue-ID: QUE-20260106-164500 - Item-ID: S-9 ## Tasks Completed - T1: Create shared RouteContext type definition - T2: Remove @ts-nocheck from small route files - T3: Remove @ts-nocheck from medium route files - T4: Remove @ts-nocheck from large route files - T5: Remove @ts-nocheck from remaining core files ## Files Modified - ccw/src/core/dashboard-generator-patch.ts - ccw/src/core/dashboard-generator.ts - ccw/src/core/routes/ccw-routes.ts - ccw/src/core/routes/claude-routes.ts - ccw/src/core/routes/cli-routes.ts - ccw/src/core/routes/codexlens-routes.ts - ccw/src/core/routes/discovery-routes.ts - ccw/src/core/routes/files-routes.ts - ccw/src/core/routes/graph-routes.ts - ccw/src/core/routes/help-routes.ts - ccw/src/core/routes/hooks-routes.ts - ccw/src/core/routes/issue-routes.ts - ccw/src/core/routes/litellm-api-routes.ts - ccw/src/core/routes/litellm-routes.ts - ccw/src/core/routes/mcp-routes.ts - ccw/src/core/routes/mcp-routes.ts.backup - ccw/src/core/routes/mcp-templates-db.ts - ccw/src/core/routes/nav-status-routes.ts - ccw/src/core/routes/rules-routes.ts - ccw/src/core/routes/session-routes.ts - ccw/src/core/routes/skills-routes.ts - ccw/src/core/routes/status-routes.ts - ccw/src/core/routes/system-routes.ts - ccw/src/core/routes/types.ts - ccw/src/core/server.ts - ccw/src/core/websocket.ts ## Verification - npm run build - npm test * refactor: split cli-executor and codexlens routes into modules ## Solution Summary - Solution-ID: SOL-DSC-012-1 - Issue-ID: DSC-012 - Risk/Impact/Complexity: medium/medium/high ## Tasks Completed - [T1] Extract execution orchestration from cli-executor.ts (Refactor ccw/src/tools) - [T2] Extract route handlers from codexlens-routes.ts (Refactor ccw/src/core/routes) - [T3] Extract prompt concatenation logic from cli-executor (Refactor ccw/src/tools) - [T4] Document refactored module architecture (Docs) ## Files Modified - ccw/src/tools/cli-executor.ts - ccw/src/tools/cli-executor-core.ts - ccw/src/tools/cli-executor-utils.ts - ccw/src/tools/cli-executor-state.ts - ccw/src/tools/cli-prompt-builder.ts - ccw/src/tools/README.md - ccw/src/core/routes/codexlens-routes.ts - ccw/src/core/routes/codexlens/config-handlers.ts - ccw/src/core/routes/codexlens/index-handlers.ts - ccw/src/core/routes/codexlens/semantic-handlers.ts - ccw/src/core/routes/codexlens/watcher-handlers.ts - ccw/src/core/routes/codexlens/utils.ts - ccw/src/core/routes/codexlens/README.md ## Verification - npm run build - npm test * test(issue): Add comprehensive issue command tests ## Solution Summary - **Solution-ID**: SOL-DSC-009-1 - **Issue-ID**: DSC-009 - **Risk/Impact/Complexity**: low/high/medium ## Tasks Completed - [T1] Create issue command test file structure: Create isolated test harness - [T2] Add JSONL read/write operation tests: Verify JSONL correctness and errors - [T3] Add issue lifecycle tests: Verify status transitions and timestamps - [T4] Add solution binding tests: Verify binding flows and error cases - [T5] Add queue formation tests: Verify queue creation, IDs, and DAG behavior - [T6] Add queue execution tests: Verify next/done/retry and status sync ## Files Modified - ccw/src/commands/issue.ts - ccw/tests/issue-command.test.ts ## Verification - node --experimental-strip-types --test ccw/tests/issue-command.test.ts * test(routes): Add integration tests for route modules ## Solution Summary - Solution-ID: SOL-DSC-010-1 - Issue-ID: DSC-010 - Queue-ID: QUE-20260106-164500 ## Tasks Completed - [T1] Add tests for ccw-routes.ts - [T2] Add tests for files-routes.ts - [T3] Add tests for claude-routes.ts (includes Windows path fix for create) - [T4] Add tests for issue-routes.ts - [T5] Add tests for help-routes.ts (avoid hanging watchers) - [T6] Add tests for nav-status-routes.ts - [T7] Add tests for hooks/graph/rules/skills/litellm-api routes ## Files Modified - ccw/src/core/routes/claude-routes.ts - ccw/src/core/routes/help-routes.ts - ccw/tests/integration/ccw-routes.test.ts - ccw/tests/integration/claude-routes.test.ts - ccw/tests/integration/files-routes.test.ts - ccw/tests/integration/issue-routes.test.ts - ccw/tests/integration/help-routes.test.ts - ccw/tests/integration/nav-status-routes.test.ts - ccw/tests/integration/hooks-routes.test.ts - ccw/tests/integration/graph-routes.test.ts - ccw/tests/integration/rules-routes.test.ts - ccw/tests/integration/skills-routes.test.ts - ccw/tests/integration/litellm-api-routes.test.ts ## Verification - node --experimental-strip-types --test ccw/tests/integration/ccw-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/files-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/claude-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/issue-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/help-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/nav-status-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/hooks-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/graph-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/rules-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/skills-routes.test.ts - node --experimental-strip-types --test ccw/tests/integration/litellm-api-routes.test.ts * refactor(core): Switch cache and lite scanning to async fs ## Solution Summary - Solution-ID: SOL-DSC-013-1 - Issue-ID: DSC-013 - Queue-ID: QUE-20260106-164500 ## Tasks Completed - [T1] Convert cache-manager.ts to async file operations - [T2] Convert lite-scanner.ts to async file operations - [T3] Update cache-manager call sites to await async API - [T4] Update lite-scanner call sites to await async API ## Files Modified - ccw/src/core/cache-manager.ts - ccw/src/core/lite-scanner.ts - ccw/src/core/data-aggregator.ts ## Verification - npm run build - npm test * fix(exec): Add timeout protection for execSync ## Solution Summary - Solution-ID: SOL-DSC-014-1 - Issue-ID: DSC-014 - Queue-ID: QUE-20260106-164500 ## Tasks Completed - [T1] Add timeout to execSync calls in python-utils.ts - [T2] Add timeout to execSync calls in detect-changed-modules.ts - [T3] Add timeout to execSync calls in claude-freshness.ts - [T4] Add timeout to execSync calls in issue.ts - [T5] Consolidate execSync timeout constants and audit coverage ## Files Modified - ccw/src/utils/exec-constants.ts - ccw/src/utils/python-utils.ts - ccw/src/tools/detect-changed-modules.ts - ccw/src/core/claude-freshness.ts - ccw/src/commands/issue.ts - ccw/src/tools/smart-search.ts - ccw/src/tools/codex-lens.ts - ccw/src/core/routes/codexlens/config-handlers.ts ## Verification - npm run build - npm test - node --experimental-strip-types --test ccw/tests/issue-command.test.ts * feat(cli): Add progress spinner with elapsed time for long-running operations ## Solution Summary - Solution-ID: SOL-DSC-015-1 - Issue-ID: DSC-015 - Queue-Item: S-15 - Risk/Impact/Complexity: low/medium/low ## Tasks Completed - [T1] Add progress spinner to CLI execution: Update ccw/src/commands/cli.ts ## Files Modified - ccw/src/commands/cli.ts - ccw/tests/cli-command.test.ts ## Verification - node --experimental-strip-types --test ccw/tests/cli-command.test.ts - node --experimental-strip-types --test ccw/tests/cli-executor-kill.test.ts - node --experimental-strip-types --test ccw/tests/cli-executor-merge-validation.test.ts * fix(cli): Move full output hint immediately after truncation notice ## Solution Summary - Solution-ID: SOL-DSC-016-1 - Issue-ID: DSC-016 - Queue-Item: S-16 - Risk/Impact/Complexity: low/high/low ## Tasks Completed - [T1] Relocate output hint after truncation: Update ccw/src/commands/cli.ts ## Files Modified - ccw/src/commands/cli.ts - ccw/tests/cli-command.test.ts ## Verification - npm run build - node --experimental-strip-types --test ccw/tests/cli-command.test.ts * feat(cli): Add confirmation prompts for destructive operations ## Solution Summary - Solution-ID: SOL-DSC-017-1 - Issue-ID: DSC-017 - Queue-Item: S-17 - Risk/Impact/Complexity: low/high/low ## Tasks Completed - [T1] Add confirmation to storage clean operations: Update ccw/src/commands/cli.ts - [T2] Add confirmation to issue queue delete: Update ccw/src/commands/issue.ts ## Files Modified - ccw/src/commands/cli.ts - ccw/src/commands/issue.ts - ccw/tests/cli-command.test.ts - ccw/tests/issue-command.test.ts ## Verification - npm run build - node --experimental-strip-types --test ccw/tests/cli-command.test.ts - node --experimental-strip-types --test ccw/tests/issue-command.test.ts * feat(cli): Improve multi-line prompt guidance ## Solution Summary - Solution-ID: SOL-DSC-018-1 - Issue-ID: DSC-018 - Queue-Item: S-18 - Risk/Impact/Complexity: low/medium/low ## Tasks Completed - [T1] Update CLI help to emphasize --file option: Update ccw/src/commands/cli.ts - [T2] Add inline hint for multi-line detection: Update ccw/src/commands/cli.ts ## Files Modified - ccw/src/commands/cli.ts - ccw/tests/cli-command.test.ts ## Verification - npm run build - node --experimental-strip-types --test ccw/tests/cli-command.test.ts --------- Co-authored-by: catlog22 <catlog22@github.com>
443 lines
16 KiB
TypeScript
443 lines
16 KiB
TypeScript
/**
|
|
* Unit tests for CLI command module (ccw cli)
|
|
*
|
|
* Notes:
|
|
* - Targets the runtime implementation shipped in `ccw/dist`.
|
|
* - Uses Node's built-in test runner (node:test).
|
|
* - Mocks external tool execution and dashboard notification.
|
|
*/
|
|
|
|
import { after, afterEach, before, describe, it, mock } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import http from 'node:http';
|
|
import { existsSync, mkdtempSync, mkdirSync, rmSync, writeFileSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
import inquirer from 'inquirer';
|
|
|
|
const TEST_CCW_HOME = mkdtempSync(join(tmpdir(), 'ccw-cli-command-'));
|
|
process.env.CCW_DATA_DIR = TEST_CCW_HOME;
|
|
|
|
const cliCommandPath = new URL('../dist/commands/cli.js', import.meta.url).href;
|
|
const cliExecutorPath = new URL('../dist/tools/cli-executor.js', import.meta.url).href;
|
|
const historyStorePath = new URL('../dist/tools/cli-history-store.js', import.meta.url).href;
|
|
const storageManagerPath = new URL('../dist/tools/storage-manager.js', import.meta.url).href;
|
|
|
|
function stubHttpRequest(): void {
|
|
mock.method(http, 'request', () => {
|
|
const req: {
|
|
on: (event: string, handler: (arg?: any) => void) => typeof req;
|
|
write: (data: any) => void;
|
|
end: () => void;
|
|
destroy: () => void;
|
|
} = {
|
|
on(event, handler) {
|
|
if (event === 'socket') {
|
|
handler({ unref() {} });
|
|
}
|
|
return req;
|
|
},
|
|
write() {},
|
|
end() {},
|
|
destroy() {},
|
|
};
|
|
return req as any;
|
|
});
|
|
}
|
|
|
|
describe('cli command module', async () => {
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
let cliModule: any;
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
let cliExecutorModule: any;
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
let historyStoreModule: any;
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
let storageManagerModule: any;
|
|
|
|
before(async () => {
|
|
cliModule = await import(cliCommandPath);
|
|
cliExecutorModule = await import(cliExecutorPath);
|
|
historyStoreModule = await import(historyStorePath);
|
|
storageManagerModule = await import(storageManagerPath);
|
|
});
|
|
|
|
afterEach(() => {
|
|
mock.restoreAll();
|
|
});
|
|
|
|
after(() => {
|
|
try {
|
|
historyStoreModule?.closeAllStores?.();
|
|
} catch {
|
|
// ignore
|
|
}
|
|
rmSync(TEST_CCW_HOME, { recursive: true, force: true });
|
|
});
|
|
|
|
it('executes tool (gemini/qwen/codex) and passes parameters to executor', async () => {
|
|
stubHttpRequest();
|
|
mock.method(console, 'log', () => {});
|
|
mock.method(console, 'error', () => {});
|
|
|
|
const calls: any[] = [];
|
|
mock.method(cliExecutorModule.cliExecutorTool, 'execute', async (params: any) => {
|
|
calls.push(params);
|
|
return {
|
|
success: true,
|
|
stdout: 'ok',
|
|
stderr: '',
|
|
execution: { id: 'EXEC-1', duration_ms: 12, status: 'success' },
|
|
conversation: { turn_count: 1, total_duration_ms: 12 },
|
|
};
|
|
});
|
|
|
|
const exitCodes: Array<number | undefined> = [];
|
|
mock.method(process as any, 'exit', (code?: number) => {
|
|
exitCodes.push(code);
|
|
});
|
|
|
|
for (const tool of ['gemini', 'qwen', 'codex']) {
|
|
await cliModule.cliCommand('exec', [], { prompt: 'Hello', tool });
|
|
}
|
|
|
|
// `ccw/dist` schedules process exit with a small timeout for "fire-and-forget" dashboard notification.
|
|
await new Promise((resolve) => setTimeout(resolve, 150));
|
|
|
|
assert.deepEqual(
|
|
calls.map((c) => c.tool),
|
|
['gemini', 'qwen', 'codex'],
|
|
);
|
|
for (const call of calls) {
|
|
assert.equal(call.prompt, 'Hello');
|
|
assert.equal(call.mode, 'analysis');
|
|
assert.equal(call.stream, false);
|
|
assert.equal(call.timeout, 0);
|
|
}
|
|
assert.deepEqual(exitCodes, [0, 0, 0]);
|
|
});
|
|
|
|
it('prints a --file tip when a multi-line prompt is provided via --prompt', async () => {
|
|
stubHttpRequest();
|
|
|
|
const logs: string[] = [];
|
|
mock.method(console, 'log', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
mock.method(console, 'error', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
|
|
mock.method(cliExecutorModule.cliExecutorTool, 'execute', async () => {
|
|
return {
|
|
success: true,
|
|
stdout: '',
|
|
stderr: '',
|
|
execution: { id: 'EXEC-ML', duration_ms: 1, status: 'success' },
|
|
conversation: { turn_count: 1, total_duration_ms: 1 },
|
|
};
|
|
});
|
|
|
|
const exitCodes: Array<number | undefined> = [];
|
|
mock.method(process as any, 'exit', (code?: number) => {
|
|
exitCodes.push(code);
|
|
});
|
|
|
|
await cliModule.cliCommand('exec', [], { prompt: 'line1\nline2\nline3\nline4', tool: 'gemini', stream: true });
|
|
await new Promise((resolve) => setTimeout(resolve, 200));
|
|
|
|
assert.ok(logs.some((l) => l.includes('Tip: Use --file option to avoid shell escaping issues with multi-line prompts')));
|
|
assert.ok(logs.some((l) => l.includes('Example: ccw cli -f prompt.txt --tool gemini')));
|
|
assert.deepEqual(exitCodes, [0]);
|
|
});
|
|
|
|
it('does not print the --file tip for single-line prompts', async () => {
|
|
stubHttpRequest();
|
|
|
|
const logs: string[] = [];
|
|
mock.method(console, 'log', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
mock.method(console, 'error', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
|
|
mock.method(cliExecutorModule.cliExecutorTool, 'execute', async () => {
|
|
return {
|
|
success: true,
|
|
stdout: '',
|
|
stderr: '',
|
|
execution: { id: 'EXEC-SL', duration_ms: 1, status: 'success' },
|
|
conversation: { turn_count: 1, total_duration_ms: 1 },
|
|
};
|
|
});
|
|
|
|
const exitCodes: Array<number | undefined> = [];
|
|
mock.method(process as any, 'exit', (code?: number) => {
|
|
exitCodes.push(code);
|
|
});
|
|
|
|
await cliModule.cliCommand('exec', [], { prompt: 'Hello', tool: 'gemini', stream: true });
|
|
await new Promise((resolve) => setTimeout(resolve, 200));
|
|
|
|
assert.equal(
|
|
logs.some((l) => l.includes('Tip: Use --file option to avoid shell escaping issues with multi-line prompts')),
|
|
false,
|
|
);
|
|
assert.deepEqual(exitCodes, [0]);
|
|
});
|
|
|
|
it('prints full output hint immediately after stderr truncation (no troubleshooting duplicate)', async () => {
|
|
stubHttpRequest();
|
|
|
|
const logs: string[] = [];
|
|
mock.method(console, 'log', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
mock.method(console, 'error', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
|
|
mock.method(cliExecutorModule.cliExecutorTool, 'execute', async () => {
|
|
const stderr = Array.from({ length: 31 }, (_, i) => `stderr-line-${i}`).join('\n');
|
|
return {
|
|
success: false,
|
|
stdout: '',
|
|
stderr,
|
|
execution: { id: 'EXEC-ERR', duration_ms: 12, status: 'error', exit_code: 1 },
|
|
conversation: { turn_count: 1, total_duration_ms: 12 },
|
|
};
|
|
});
|
|
|
|
const exitCodes: Array<number | undefined> = [];
|
|
mock.method(process as any, 'exit', (code?: number) => {
|
|
exitCodes.push(code);
|
|
});
|
|
|
|
await cliModule.cliCommand('exec', [], { prompt: 'Hello', tool: 'gemini', stream: true });
|
|
await new Promise((resolve) => setTimeout(resolve, 200));
|
|
|
|
const truncationIndex = logs.findIndex((l) => l.includes('... 1 more lines'));
|
|
const hintIndex = logs.findIndex((l) => l.includes('💡 View full output: ccw cli output EXEC-ERR'));
|
|
assert.ok(truncationIndex >= 0);
|
|
assert.ok(hintIndex >= 0);
|
|
assert.equal(hintIndex, truncationIndex + 1);
|
|
|
|
assert.equal(logs.filter((l) => l.includes('View full output: ccw cli output EXEC-ERR')).length, 1);
|
|
assert.equal(logs.filter((l) => l.includes('• View full output')).length, 0);
|
|
assert.deepEqual(exitCodes, [1]);
|
|
});
|
|
|
|
it('supports resume with conversation ID and latest (no prompt required)', async () => {
|
|
stubHttpRequest();
|
|
mock.method(console, 'log', () => {});
|
|
mock.method(console, 'error', () => {});
|
|
|
|
const resumes: any[] = [];
|
|
mock.method(cliExecutorModule.cliExecutorTool, 'execute', async (params: any) => {
|
|
resumes.push(params.resume);
|
|
return {
|
|
success: true,
|
|
stdout: '',
|
|
stderr: '',
|
|
execution: { id: 'EXEC-R', duration_ms: 1, status: 'success' },
|
|
conversation: { turn_count: 2, total_duration_ms: 1 },
|
|
};
|
|
});
|
|
|
|
const exitCodes: Array<number | undefined> = [];
|
|
mock.method(process as any, 'exit', (code?: number) => {
|
|
exitCodes.push(code);
|
|
});
|
|
|
|
await cliModule.cliCommand('exec', [], { tool: 'gemini', resume: true });
|
|
await cliModule.cliCommand('exec', [], { tool: 'gemini', resume: 'CONV-123' });
|
|
|
|
await new Promise((resolve) => setTimeout(resolve, 150));
|
|
|
|
assert.deepEqual(resumes, [true, 'CONV-123']);
|
|
assert.deepEqual(exitCodes, [0, 0]);
|
|
});
|
|
|
|
it('validates prompt requirement when not resuming', async () => {
|
|
stubHttpRequest();
|
|
|
|
class ExitError extends Error {
|
|
code?: number;
|
|
|
|
constructor(code?: number) {
|
|
super(`process.exit(${code ?? 'undefined'})`);
|
|
this.code = code;
|
|
}
|
|
}
|
|
|
|
let executed = false;
|
|
mock.method(cliExecutorModule.cliExecutorTool, 'execute', async () => {
|
|
executed = true;
|
|
return {
|
|
success: true,
|
|
stdout: '',
|
|
stderr: '',
|
|
execution: { id: 'EXEC-NEVER', duration_ms: 1, status: 'success' },
|
|
conversation: { turn_count: 1, total_duration_ms: 1 },
|
|
};
|
|
});
|
|
|
|
// Use a non-subcommand-looking value so it won't be treated as a positional prompt.
|
|
// `resume: false` forces execAction path without satisfying "resuming" condition.
|
|
mock.method(process as any, 'exit', (code?: number) => {
|
|
throw new ExitError(code);
|
|
});
|
|
|
|
await assert.rejects(
|
|
cliModule.cliCommand('-ignored', [], { tool: 'gemini', resume: false }),
|
|
(err: any) => err instanceof ExitError && err.code === 1,
|
|
);
|
|
|
|
assert.equal(executed, false);
|
|
});
|
|
|
|
it('shows --file guidance first in help output (multi-line prompts)', async () => {
|
|
const logs: string[] = [];
|
|
mock.method(console, 'log', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
mock.method(console, 'error', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
|
|
await cliModule.cliCommand('--help', [], {});
|
|
|
|
const usageFileIndex = logs.findIndex((l) => l.includes('ccw cli -f prompt.txt'));
|
|
const usagePromptIndex = logs.findIndex((l) => l.includes('ccw cli -p "<prompt>"'));
|
|
assert.ok(usageFileIndex >= 0);
|
|
assert.ok(usagePromptIndex >= 0);
|
|
assert.ok(usageFileIndex < usagePromptIndex);
|
|
|
|
const optionFileIndex = logs.findIndex((l) => l.includes('-f, --file <file>'));
|
|
const optionPromptIndex = logs.findIndex((l) => l.includes('-p, --prompt <text>'));
|
|
assert.ok(optionFileIndex >= 0);
|
|
assert.ok(optionPromptIndex >= 0);
|
|
assert.ok(optionFileIndex < optionPromptIndex);
|
|
assert.ok(logs.some((l) => l.includes('Read prompt from file (recommended for multi-line prompts)')));
|
|
|
|
assert.ok(logs.some((l) => l.includes('Examples:')));
|
|
assert.ok(logs.some((l) => l.includes('ccw cli -f my-prompt.txt --tool gemini')));
|
|
assert.ok(logs.some((l) => l.includes("ccw cli -f <(cat <<'EOF'")));
|
|
assert.ok(logs.some((l) => l.includes("@'")));
|
|
assert.ok(logs.some((l) => l.includes('Out-File -Encoding utf8 prompt.tmp; ccw cli -f prompt.tmp --tool gemini')));
|
|
assert.ok(logs.some((l) => l.includes('Tip: For complex prompts, use --file to avoid shell escaping issues')));
|
|
});
|
|
|
|
it('prompts for confirmation before cleaning all storage (and cancels safely)', async () => {
|
|
const projectRoot = join(TEST_CCW_HOME, 'projects', 'test-project-cancel');
|
|
const markerDir = join(projectRoot, 'cli-history');
|
|
mkdirSync(markerDir, { recursive: true });
|
|
writeFileSync(join(markerDir, 'dummy.txt'), '1234');
|
|
|
|
const stats = storageManagerModule.getStorageStats();
|
|
const expectedSize = storageManagerModule.formatBytes(stats.totalSize);
|
|
|
|
const promptCalls: any[] = [];
|
|
mock.method(inquirer, 'prompt', async (questions: any) => {
|
|
promptCalls.push(questions);
|
|
return { proceed: false };
|
|
});
|
|
|
|
const logs: string[] = [];
|
|
mock.method(console, 'log', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
mock.method(console, 'error', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
|
|
await cliModule.cliCommand('storage', ['clean'], { force: false });
|
|
|
|
assert.equal(promptCalls.length, 1);
|
|
assert.equal(promptCalls[0][0].type, 'confirm');
|
|
assert.equal(promptCalls[0][0].default, false);
|
|
assert.ok(promptCalls[0][0].message.includes(`${stats.projectCount} projects`));
|
|
assert.ok(promptCalls[0][0].message.includes(`(${expectedSize})`));
|
|
|
|
assert.ok(logs.some((l) => l.includes('Storage clean cancelled')));
|
|
assert.equal(existsSync(projectRoot), true);
|
|
rmSync(projectRoot, { recursive: true, force: true });
|
|
});
|
|
|
|
it('bypasses confirmation prompt when --force is set for storage clean', async () => {
|
|
const projectRoot = join(TEST_CCW_HOME, 'projects', 'test-project-force');
|
|
const markerDir = join(projectRoot, 'cli-history');
|
|
mkdirSync(markerDir, { recursive: true });
|
|
writeFileSync(join(markerDir, 'dummy.txt'), '1234');
|
|
|
|
mock.method(inquirer, 'prompt', async () => {
|
|
throw new Error('inquirer.prompt should not be called when --force is set');
|
|
});
|
|
|
|
await cliModule.cliCommand('storage', ['clean'], { force: true });
|
|
assert.equal(existsSync(projectRoot), false);
|
|
});
|
|
|
|
it('deletes all storage after interactive confirmation', async () => {
|
|
const projectRoot = join(TEST_CCW_HOME, 'projects', 'test-project-confirm');
|
|
const markerDir = join(projectRoot, 'cli-history');
|
|
mkdirSync(markerDir, { recursive: true });
|
|
writeFileSync(join(markerDir, 'dummy.txt'), '1234');
|
|
|
|
mock.method(inquirer, 'prompt', async () => ({ proceed: true }));
|
|
|
|
await cliModule.cliCommand('storage', ['clean'], { force: false });
|
|
assert.equal(existsSync(projectRoot), false);
|
|
});
|
|
|
|
it('prints history and retrieves conversation detail from SQLite store', async () => {
|
|
stubHttpRequest();
|
|
|
|
const logs: string[] = [];
|
|
mock.method(console, 'log', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
mock.method(console, 'error', (...args: any[]) => {
|
|
logs.push(args.map(String).join(' '));
|
|
});
|
|
|
|
const store = historyStoreModule.getHistoryStore(process.cwd());
|
|
store.saveConversation({
|
|
id: 'CONV-CLI-1',
|
|
created_at: new Date('2025-01-01T00:00:00.000Z').toISOString(),
|
|
updated_at: new Date('2025-01-01T00:00:01.000Z').toISOString(),
|
|
tool: 'gemini',
|
|
model: 'default',
|
|
mode: 'analysis',
|
|
category: 'user',
|
|
total_duration_ms: 123,
|
|
turn_count: 1,
|
|
latest_status: 'success',
|
|
turns: [
|
|
{
|
|
turn: 1,
|
|
timestamp: new Date('2025-01-01T00:00:00.000Z').toISOString(),
|
|
prompt: 'Test prompt',
|
|
duration_ms: 123,
|
|
status: 'success',
|
|
exit_code: 0,
|
|
output: { stdout: 'OK', stderr: '', truncated: false, cached: false },
|
|
},
|
|
],
|
|
});
|
|
|
|
await cliModule.cliCommand('history', [], { limit: '20' });
|
|
assert.ok(logs.some((l) => l.includes('CONV-CLI-1')));
|
|
|
|
// Ensure cli-executor SQLite module is initialized for sync detail retrieval
|
|
await cliExecutorModule.getExecutionHistoryAsync(process.cwd(), { limit: 1 });
|
|
|
|
logs.length = 0;
|
|
await cliModule.cliCommand('detail', ['CONV-CLI-1'], {});
|
|
assert.ok(logs.some((l) => l.includes('Conversation Detail')));
|
|
assert.ok(logs.some((l) => l.includes('CONV-CLI-1')));
|
|
assert.ok(logs.some((l) => l.includes('Test prompt')));
|
|
});
|
|
});
|