mirror of https://github.com/catlog22/Claude-Code-Workflow.git synced 2026-03-26 19:56:37 +08:00

Files

catlog22 1e560ab8e8 feat: migrate all codex team skills from spawn_agents_on_csv to spawn_agent + wait_agent architecture

- Delete 21 old team skill directories using CSV-wave pipeline pattern (~100+ files)
- Delete old team-lifecycle (v3) and team-planex-v2
- Create generic team-worker.toml and team-supervisor.toml (replacing tlv4-specific TOMLs)
- Convert 19 team skills from Claude Code format (Agent/SendMessage/TaskCreate)
  to Codex format (spawn_agent/wait_agent/tasks.json/request_user_input)
- Update team-lifecycle-v4 to use generic agent types (team_worker/team_supervisor)
- Convert all coordinator role files: dispatch.md, monitor.md, role.md
- Convert all worker role files: remove run_in_background, fix Bash syntax
- Convert all specs/pipelines.md references
- Final state: 20 team skills, 217 .md files, zero Claude Code API residuals

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-03-24 16:54:48 +08:00

1.7 KiB

Raw Blame History

Code Review

4-dimension code review for implementation quality.

Inputs

Plan file ({session}/plan/plan.json)
Implementation discovery files ({session}/discoveries/IMPL-*.json)
Test results (if available)

Gather Modified Files

Read upstream context from file system (no team_msg):

// 1. Read plan for file list
const plan = JSON.parse(Read(`{session}/plan/plan.json`))
const plannedFiles = plan.tasks.flatMap(t => t.files)

// 2. Read implementation discoveries for actual modified files
const implFiles = Glob(`{session}/discoveries/IMPL-*.json`)
const modifiedFiles = new Set()
for (const f of implFiles) {
  const discovery = JSON.parse(Read(f))
  for (const file of (discovery.files_modified || [])) {
    modifiedFiles.add(file)
  }
}

// 3. Union of planned + actually modified files
const allFiles = [...new Set([...plannedFiles, ...modifiedFiles])]

Dimensions

Dimension	Critical Issues
Quality	Empty catch, any casts, @ts-ignore, console.log
Security	Hardcoded secrets, SQL injection, eval/exec, innerHTML
Architecture	Circular deps, imports >2 levels deep, files >500 lines
Requirements	Missing core functionality, incomplete acceptance criteria

Review Process

Gather modified files from plan.json + discoveries/IMPL-*.json
Read each modified file
Score per dimension (0-100%)
Classify issues by severity (Critical/High/Medium/Low)
Generate verdict (BLOCK/CONDITIONAL/APPROVE)

Output

Write review report to {session}/artifacts/review-report.md:

Per-dimension scores
Issue list with file:line references
Verdict with justification
Recommendations (if CONDITIONAL)

1.7 KiB Raw Blame History