mirror of https://github.com/catlog22/Claude-Code-Workflow.git synced 2026-02-14 02:42:04 +08:00

Files

catlog22 d43696d756 feat: Implement phases 6 to 9 of the review cycle fix process, including discovery, batching, parallel planning, execution, and completion

- Added Phase 6: Fix Discovery & Batching with intelligent grouping and batching of findings.
- Added Phase 7: Fix Parallel Planning to launch planning agents for concurrent analysis and aggregation of partial plans.
- Added Phase 8: Fix Execution for stage-based execution of fixes with conservative test verification.
- Added Phase 9: Fix Completion to aggregate results, generate summary reports, and handle session completion.
- Introduced new frontend components: ResizeHandle for draggable resizing of sidebar panels and useResizablePanel hook for managing panel sizes with localStorage persistence.
- Added PowerShell script for checking TypeScript errors in source code, excluding test files.

2026-02-07 19:28:33 +08:00

10 KiB

Raw Blame History

Phase 1: Discovery & Initialization

Source: Fused from commands/workflow/review-session-cycle.md Phase 1 + commands/workflow/review-module-cycle.md Phase 1

Overview

Detect review mode (session or module), resolve target files, create workflow session, initialize output directory structure and state files.

Mode Detection

The review mode is determined by the input arguments:

Session mode: No path pattern provided, OR a WFS-* session ID is provided. Reviews all changes within an existing workflow session (git-based change detection).
Module mode: Glob/path patterns are provided (e.g., src/auth/**, src/payment/processor.ts). Reviews specific files/directories regardless of session history.

Session Mode (review-session-cycle)

Step 1.1: Session Discovery

// If session ID not provided, auto-detect
if (!providedSessionId) {
  // Check for active sessions
  const activeSessions = Glob('.workflow/active/WFS-*');
  if (activeSessions.length === 1) {
    sessionId = activeSessions[0].match(/WFS-[^/]+/)[0];
  } else if (activeSessions.length > 1) {
    // List sessions and prompt user
    error("Multiple active sessions found. Please specify session ID.");
  } else {
    error("No active session found. Create session first.");
  }
} else {
  sessionId = providedSessionId;
}

// Validate session exists
Bash(`test -d .workflow/active/${sessionId} && echo "EXISTS"`);

Step 1.2: Session Validation

Ensure session has implementation artifacts (check .summaries/ or .task/ directory)
Extract session creation timestamp from workflow-session.json
Use timestamp for git log filtering: git log --since="${sessionCreatedAt}"

Step 1.3: Changed Files Detection

# Get files changed since session creation
git log --since="${sessionCreatedAt}" --name-only --pretty=format: | sort -u

Module Mode (review-module-cycle)

Step 1.1: Session Creation

// Create workflow session for this review (type: review)
// Orchestrator handles session creation directly
Bash(`mkdir -p .workflow/active/WFS-review-${Date.now()}`);

// Initialize workflow-session.json
const sessionId = `WFS-review-${Date.now()}`;
Write(`.workflow/active/${sessionId}/workflow-session.json`, JSON.stringify({
  session_id: sessionId,
  type: "review",
  description: `Code review for ${targetPattern}`,
  created_at: new Date().toISOString()
}, null, 2));

Step 1.2: Path Resolution & Validation

# Expand glob pattern to file list (relative paths from project root)
find . -path "./src/auth/**" -type f | sed 's|^\./||'

# Validate files exist and are readable
for file in ${resolvedFiles[@]}; do
  test -r "$file" || error "File not readable: $file"
done

Parse and expand file patterns (glob support): src/auth/** -> actual file list
Validation: Ensure all specified files exist and are readable
Store as relative paths from project root (e.g., src/auth/service.ts)
Agents construct absolute paths dynamically during execution

Syntax Rules:

All paths are relative from project root (e.g., src/auth/** not /src/auth/**)
Multiple patterns: comma-separated, no spaces (e.g., src/auth/**,src/payment/**)
Glob and specific files can be mixed (e.g., src/auth/**,src/config.ts)

Supported Patterns:

Pattern Type	Example	Description
Glob directory	`src/auth/**`	All files under src/auth/
Glob with extension	`src/*/.ts`	All .ts files under src/
Specific file	`src/payment/processor.ts`	Single file
Multiple patterns	`src/auth/,src/payment/`	Comma-separated (no spaces)

Resolution Process:

Parse input pattern (split by comma, trim whitespace)
Expand glob patterns to file list via find command
Validate all files exist and are readable
Error if pattern matches 0 files
Store resolved file list in review-state.json

Common Steps (Both Modes)

Step 1.4: Output Directory Setup

Output directory: .workflow/active/${sessionId}/.review/

Create directory structure:

mkdir -p ${sessionDir}/.review/{dimensions,iterations,reports}

Step 1.5: Initialize Review State

State initialization: Create review-state.json with metadata, dimensions, max_iterations (merged metadata + state)
Session mode includes git_changes in metadata
Module mode includes target_pattern and resolved_files in metadata
Progress tracking: Create review-progress.json for progress tracking

Step 1.6: Initialize Review Progress

Create review-progress.json for real-time dashboard updates via polling
See Review Progress JSON schema below

Step 1.7: Progress Tracking Initialization

Set up progress tracking with hierarchical structure
Mark Phase 1 completed, Phase 2 in_progress

Review State JSON (Session Mode)

Purpose: Unified state machine and metadata (merged from metadata + state)

{
  "session_id": "WFS-payment-integration",
  "review_id": "review-20250125-143022",
  "review_type": "session",
  "metadata": {
    "created_at": "2025-01-25T14:30:22Z",
    "git_changes": {
      "commit_range": "abc123..def456",
      "files_changed": 15,
      "insertions": 342,
      "deletions": 128
    },
    "dimensions": ["security", "architecture", "quality", "action-items", "performance", "maintainability", "best-practices"],
    "max_iterations": 3
  },
  "phase": "parallel|aggregate|iterate|complete",
  "current_iteration": 1,
  "dimensions_reviewed": ["security", "architecture", "quality", "action-items", "performance", "maintainability", "best-practices"],
  "selected_strategy": "comprehensive",
  "next_action": "execute_parallel_reviews|aggregate_findings|execute_deep_dive|generate_final_report|complete",
  "severity_distribution": {
    "critical": 2,
    "high": 5,
    "medium": 12,
    "low": 8
  },
  "critical_files": [
    {
      "file": "src/payment/processor.ts",
      "finding_count": 5,
      "dimensions": ["security", "architecture", "quality"]
    }
  ],
  "iterations": [
    {
      "iteration": 1,
      "findings_analyzed": ["uuid-1", "uuid-2"],
      "findings_resolved": 1,
      "findings_escalated": 1,
      "severity_change": {
        "before": {"critical": 2, "high": 5, "medium": 12, "low": 8},
        "after": {"critical": 1, "high": 6, "medium": 12, "low": 8}
      },
      "timestamp": "2025-01-25T14:30:00Z"
    }
  ],
  "completion_criteria": {
    "target": "no_critical_findings_and_high_under_5",
    "current_status": "in_progress",
    "estimated_completion": "2 iterations remaining"
  }
}

Field Descriptions:

phase: Current execution phase (state machine pointer)
current_iteration: Iteration counter (used for max check)
next_action: Next step orchestrator should execute
severity_distribution: Aggregated counts across all dimensions
critical_files: Files appearing in 3+ dimensions with metadata
iterations[]: Historical log for trend analysis

Review State JSON (Module Mode)