Files
Claude-Code-Workflow/.claude/skills/team-review/role-specs/fixer.md
catlog22 26bda9c634 feat: Add coordinator commands and role specifications for UI design team
- Implemented the 'monitor' command for coordinator role to handle monitoring events, task completion, and pipeline management.
- Created role specifications for the coordinator, detailing responsibilities, command execution protocols, and session management.
- Added role specifications for the analyst, discussant, explorer, and synthesizer in the ultra-analyze skill, defining their context loading, analysis, and synthesis processes.
2026-03-03 23:35:41 +08:00

3.2 KiB

prefix, inner_loop, message_types
prefix inner_loop message_types
FIX true
success error
fix_complete fix_failed

Code Fixer

Fix code based on reviewed findings. Load manifest, plan fix groups, apply with rollback-on-failure, verify. Code-generation role -- modifies source files.

Phase 2: Context & Scope Resolution

Input Source Required
Task description From task subject/description Yes
Session path Extracted from task description Yes
Fix manifest /fix/fix-manifest.json Yes
Review report /review/review-report.json Yes
.msg/meta.json /.msg/meta.json No
  1. Extract session path, input path from task description
  2. Load manifest (scope, source report path) and review report (findings with enrichment)
  3. Filter fixable findings: severity in scope AND fix_strategy !== 'skip'
  4. If 0 fixable -> report complete immediately
  5. Detect quick path: findings <= 5 AND no cross-file dependencies
  6. Detect verification tools: tsc (tsconfig.json), eslint (package.json), jest (package.json), pytest (pyproject.toml), semgrep (semgrep available)
  7. Load wisdom files from <session>/wisdom/

Phase 3: Plan + Execute

3A: Plan Fixes (deterministic, no CLI)

  1. Group findings by primary file
  2. Merge groups with cross-file dependencies (union-find)
  3. Topological sort within each group (respect fix_dependencies, append cycles at end)
  4. Sort groups by max severity (critical first)
  5. Determine execution path: quick_path (<=5 findings, <=1 group) or standard
  6. Write <session>/fix/fix-plan.json: {plan_id, quick_path, groups[{id, files[], findings[], max_severity}], execution_order[], total_findings, total_groups}

3B: Execute Fixes

Quick path: Single code-developer agent for all findings. Standard path: One code-developer agent per group, in execution_order.

Agent prompt includes: finding list (dependency-sorted), file contents (truncated 8K), critical rules:

  1. Apply each fix using Edit tool in order
  2. After each fix, run related tests
  3. Tests PASS -> finding is "fixed"
  4. Tests FAIL -> git checkout -- {file} -> mark "failed" -> continue
  5. No retry on failure. Rollback and move on
  6. If finding depends on previously failed finding -> mark "skipped"

Agent returns JSON: {results:[{id, status: fixed|failed|skipped, file, error?}]} Fallback: check git diff per file if no structured output.

Write <session>/fix/execution-results.json: {fixed[], failed[], skipped[]}

Phase 4: Post-Fix Verification

  1. Run available verification tools on modified files:
Tool Command Pass Criteria
tsc npx tsc --noEmit 0 errors
eslint npx eslint <files> 0 errors
jest npx jest --passWithNoTests Tests pass
pytest pytest --tb=short Tests pass
semgrep semgrep --config auto <files> --json 0 results
  1. If verification fails critically -> rollback last batch
  2. Write <session>/fix/verify-results.json
  3. Generate <session>/fix/fix-summary.json: {fix_id, fix_date, scope, total, fixed, failed, skipped, fix_rate, verification}
  4. Generate <session>/fix/fix-summary.md (human-readable)
  5. Update <session>/.msg/meta.json with fix results
  6. Contribute discoveries to <session>/wisdom/ files