cexll/myclaude
1
0
Fork 0
mirror of https://github.com/cexll/myclaude.git synced 2026-02-14 03:31:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): set USERPROFILE on Windows for skills tests

Browse Source 
os.UserHomeDir() uses USERPROFILE on Windows, not HOME. Add
setTestHome helper that sets both env vars for cross-platform
compatibility in CI.

Generated with SWE-Agent.ai

Co-Authored-By: SWE-Agent.ai <noreply@swe-agent.ai>
This commit is contained in:
cexll
2026-02-09 11:16:33 +08:00
parent 97dfa907d9
commit 8db49f198e
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
codeagent-wrapper/internal/executor/skills_test.go
View File

@@ -3,10 +3,20 @@ package executor
import ( import (
"os" "os"
"path/filepath" "path/filepath"
"runtime"
"strings" "strings"
"testing" "testing"
) )
// setTestHome overrides the home directory for both Unix (HOME) and Windows (USERPROFILE).
func setTestHome(t *testing.T, home string) {
t.Helper()
t.Setenv("HOME", home)
if runtime.GOOS == "windows" {
t.Setenv("USERPROFILE", home)
}
}
// --- helper: create a temp skill dir with SKILL.md --- // --- helper: create a temp skill dir with SKILL.md ---
func createTempSkill(t *testing.T, name, content string) string { func createTempSkill(t *testing.T, name, content string) string {
@@ -195,7 +205,7 @@ func TestDetectProjectSkills_NonexistentDir(t *testing.T) {
func TestResolveSkillContent_ValidSkill(t *testing.T) { func TestResolveSkillContent_ValidSkill(t *testing.T) {
home := createTempSkill(t, "test-skill", "---\nname: test\n---\n\n# Test Skill\nBest practices here.") home := createTempSkill(t, "test-skill", "---\nname: test\n---\n\n# Test Skill\nBest practices here.")
t.Setenv("HOME", home) setTestHome(t, home)
result := ResolveSkillContent([]string{"test-skill"}, 0) result := ResolveSkillContent([]string{"test-skill"}, 0)
if result == "" { if result == "" {
@@ -217,7 +227,7 @@ func TestResolveSkillContent_ValidSkill(t *testing.T) {
func TestResolveSkillContent_NonexistentSkill(t *testing.T) { func TestResolveSkillContent_NonexistentSkill(t *testing.T) {
home := t.TempDir() home := t.TempDir()
t.Setenv("HOME", home) setTestHome(t, home)
result := ResolveSkillContent([]string{"nonexistent-skill-xyz"}, 0) result := ResolveSkillContent([]string{"nonexistent-skill-xyz"}, 0)
if result != "" { if result != "" {
@@ -237,7 +247,7 @@ func TestResolveSkillContent_Empty(t *testing.T) {
func TestResolveSkillContent_Budget(t *testing.T) { func TestResolveSkillContent_Budget(t *testing.T) {
longBody := strings.Repeat("x", 500) longBody := strings.Repeat("x", 500)
home := createTempSkill(t, "big-skill", "---\nname: big\n---\n\n"+longBody) home := createTempSkill(t, "big-skill", "---\nname: big\n---\n\n"+longBody)
t.Setenv("HOME", home) setTestHome(t, home)
result := ResolveSkillContent([]string{"big-skill"}, 200) result := ResolveSkillContent([]string{"big-skill"}, 200)
if result == "" { if result == "" {
@@ -256,7 +266,7 @@ func TestResolveSkillContent_MultipleSkills(t *testing.T) {
os.MkdirAll(skillDir, 0755) os.MkdirAll(skillDir, 0755)
os.WriteFile(filepath.Join(skillDir, "SKILL.md"), []byte("# "+name+"\nContent."), 0644) os.WriteFile(filepath.Join(skillDir, "SKILL.md"), []byte("# "+name+"\nContent."), 0644)
} }
t.Setenv("HOME", home) setTestHome(t, home)
result := ResolveSkillContent([]string{"skill-a", "skill-b"}, 0) result := ResolveSkillContent([]string{"skill-a", "skill-b"}, 0)
if result == "" { if result == "" {
@@ -272,7 +282,7 @@ func TestResolveSkillContent_MultipleSkills(t *testing.T) {
func TestResolveSkillContent_PathTraversal(t *testing.T) { func TestResolveSkillContent_PathTraversal(t *testing.T) {
home := t.TempDir() home := t.TempDir()
t.Setenv("HOME", home) setTestHome(t, home)
result := ResolveSkillContent([]string{"../../../etc/passwd"}, 0) result := ResolveSkillContent([]string{"../../../etc/passwd"}, 0)
if result != "" { if result != "" {
@@ -282,7 +292,7 @@ func TestResolveSkillContent_PathTraversal(t *testing.T) {
func TestResolveSkillContent_InvalidNames(t *testing.T) { func TestResolveSkillContent_InvalidNames(t *testing.T) {
home := t.TempDir() home := t.TempDir()
t.Setenv("HOME", home) setTestHome(t, home)
tests := []string{"../bad", "foo/bar", "skill name", "skill.name", "a b"} tests := []string{"../bad", "foo/bar", "skill name", "skill.name", "a b"}
for _, name := range tests { for _, name := range tests {
@@ -312,7 +322,7 @@ func TestResolveSkillContent_ValidNamePattern(t *testing.T) {
func TestSkillInjectionFormat(t *testing.T) { func TestSkillInjectionFormat(t *testing.T) {
home := createTempSkill(t, "test-go", "---\nname: go\n---\n\n# Go Best Practices\nUse gofmt.") home := createTempSkill(t, "test-go", "---\nname: go\n---\n\n# Go Best Practices\nUse gofmt.")
t.Setenv("HOME", home) setTestHome(t, home)
taskText := "Implement the feature." taskText := "Implement the feature."
content := ResolveSkillContent([]string{"test-go"}, 0) content := ResolveSkillContent([]string{"test-go"}, 0)