cexll/myclaude
1
0
Fork 0
mirror of https://github.com/cexll/myclaude.git synced 2026-02-05 02:30:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
215 Commits 21 Branches 65 Tags
v5.4.0
Commit Graph

6 Commits

Author SHA1 Message Date
cexll
af1c860f54 fix: code review fixes for PR #94 - all critical and major issues resolved 
This commit addresses all Critical and Major issues identified in the code review:

Critical Issues Fixed:
- #1: Test statistics data loss (utils.go:480) - Changed exit condition from || to &&
- #2: Below-target header showing "below 0%" - Added defaultCoverageTarget constant

Major Issues Fixed:
- #3: Coverage extraction not robust - Relaxed trigger conditions for various formats
- #4: 0% coverage ignored - Changed from CoverageNum>0 to Coverage!="" check
- #5: File change extraction incomplete - Support root files and @ prefix
- #6: String truncation panic risk - Added safeTruncate() with rune-based truncation
- #7: Breaking change documentation missing - Updated help text and docs
- #8: .DS_Store garbage files - Removed files and updated .gitignore
- #9: Test coverage insufficient - Added 29+ test cases in utils_test.go
- #10: Terminal escape injection risk - Added sanitizeOutput() for ANSI cleaning
- #11: Redundant code - Removed unused patterns variable

Test Results:
- All tests pass: go test ./... (34.283s)
- Test coverage: 88.4% (up from ~85%)
- New test file: codeagent-wrapper/utils_test.go
- No breaking changes to existing functionality

Files Modified:
- codeagent-wrapper/utils.go (+166 lines) - Core fixes and new functions
- codeagent-wrapper/executor.go (+111 lines) - Output format fixes
- codeagent-wrapper/main.go (+45 lines) - Configuration updates
- codeagent-wrapper/main_test.go (+40 lines) - New integration tests
- codeagent-wrapper/utils_test.go (new file) - Complete extractor tests
- docs/CODEAGENT-WRAPPER.md (+38 lines) - Documentation updates
- .gitignore (+2 lines) - Added .DS_Store patterns
- Deleted 5 .DS_Store files

Verification:
- Binary compiles successfully (v5.4.0)
- All extractors validated with real-world test cases
- Security vulnerabilities patched
- Performance maintained (90% token reduction preserved)

Related: #94

Generated with SWE-Agent.ai

Co-Authored-By: SWE-Agent.ai <noreply@swe-agent.ai>
 2025-12-24 09:55:39 +08:00
tytsxai
70b1896011 feat(codeagent-wrapper): v5.4.0 structured execution report (#94) 
Merging PR #94 with code review fixes applied.

All Critical and Major issues from code review have been addressed:
- 11/13 issues fixed (2 minor optimizations deferred)
- Test coverage: 88.4%
- All tests passing
- Security vulnerabilities patched
- Documentation updated

The code review fixes have been committed to pr-94 branch and are ready for integration.
 2025-12-24 09:53:58 +08:00
swe-agent[bot]
5cd1103b85 update enhance-prompt.md response 2025-11-04 16:04:11 +08:00
swe-agent[bot]
e2f80508b5 docs: 新增 /enhance-prompt 命令并更新所有 README 文档 2025-11-04 14:24:55 +08:00
swe-agent[bot]
394013fb2e Fix plugin configuration: rename to marketplace.json and update repository URLs 
- Rename plugin.json to marketplace.json in all plugin directories
- Update repository URLs from yourusername to cexll
- Fix author URL, homepage, and repository fields

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-18 17:16:42 +00:00
swe-agent[bot]
c344a2f544 Fix #10: Restructure plugin directories to ensure proper command isolation 
- Create separate directories for each plugin (requirements-driven-workflow/, bmad-agile-workflow/, development-essentials/, advanced-ai-agents/)
- Update marketplace.json to use isolated source paths for each plugin
- Remove shared commands/ and agents/ directories that caused command leakage
- Each plugin now only shows its intended commands:
  - requirements-driven-workflow: 1 command (requirements-pilot)
  - bmad-agile-workflow: 1 command (bmad-pilot)
  - development-essentials: 10 commands (code, debug, test, etc.)
  - advanced-ai-agents: 0 commands (agents only)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
 2025-10-18 01:58:23 +00:00