mirror of
https://github.com/cexll/myclaude.git
synced 2026-02-05 02:30:26 +08:00
40e2d00d35
* fix(executor): handle turn.completed and terminate process tree on Windows * fix: 修复代码审查发现的安全和资源泄漏问题 修复内容： 1. Windows 测试 taskkill 副作用：fake process 在 Windows 上返回 Pid()==0，避免真实执行 taskkill 2. taskkill PATH 劫持风险：使用 SystemRoot 环境变量构建绝对路径 3. stdinPipe 资源泄漏：在 StdoutPipe() 和 Start() 失败路径关闭 stdinPipe 4. stderr drain 并发语义：移除 500ms 超时，确保 drain 完成后再访问共享缓冲 测试验证： - go test ./... -race 通过 - TestRunCodexTask_ForcesStopAfterTurnCompleted 通过 - TestExecutorSignalAndTermination 通过 Generated with SWE-Agent.ai Co-Authored-By: SWE-Agent.ai <noreply@swe-agent.ai> --------- Co-authored-by: cexll <evanxian9@gmail.com> Co-authored-by: SWE-Agent.ai <noreply@swe-agent.ai>
65 lines
1.6 KiB
Go
65 lines
1.6 KiB
Go
//go:build windows
|
|
// +build windows
|
|
|
|
package main
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestIsProcessRunning(t *testing.T) {
|
|
t.Run("boundary values", func(t *testing.T) {
|
|
if isProcessRunning(0) {
|
|
t.Fatalf("expected pid 0 to be reported as not running")
|
|
}
|
|
if isProcessRunning(-1) {
|
|
t.Fatalf("expected pid -1 to be reported as not running")
|
|
}
|
|
})
|
|
|
|
t.Run("current process", func(t *testing.T) {
|
|
if !isProcessRunning(os.Getpid()) {
|
|
t.Fatalf("expected current process (pid=%d) to be running", os.Getpid())
|
|
}
|
|
})
|
|
|
|
t.Run("fake pid", func(t *testing.T) {
|
|
const nonexistentPID = 1 << 30
|
|
if isProcessRunning(nonexistentPID) {
|
|
t.Fatalf("expected pid %d to be reported as not running", nonexistentPID)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestGetProcessStartTimeReadsProcStat(t *testing.T) {
|
|
start := getProcessStartTime(os.Getpid())
|
|
if start.IsZero() {
|
|
t.Fatalf("expected non-zero start time for current process")
|
|
}
|
|
if start.After(time.Now().Add(5 * time.Second)) {
|
|
t.Fatalf("start time is unexpectedly in the future: %v", start)
|
|
}
|
|
}
|
|
|
|
func TestGetProcessStartTimeInvalidData(t *testing.T) {
|
|
if !getProcessStartTime(0).IsZero() {
|
|
t.Fatalf("expected zero time for pid 0")
|
|
}
|
|
if !getProcessStartTime(-1).IsZero() {
|
|
t.Fatalf("expected zero time for negative pid")
|
|
}
|
|
if !getProcessStartTime(1 << 30).IsZero() {
|
|
t.Fatalf("expected zero time for non-existent pid")
|
|
}
|
|
}
|
|
|
|
func TestGetBootTimeParsesBtime(t *testing.T) {
|
|
t.Skip("getBootTime is only implemented on Unix-like systems")
|
|
}
|
|
|
|
func TestGetBootTimeInvalidData(t *testing.T) {
|
|
t.Skip("getBootTime is only implemented on Unix-like systems")
|
|
}
|