microsoft/frontend-bootcamp
1
0
Fork 0
mirror of https://github.com/microsoft/frontend-bootcamp.git synced 2026-01-26 14:56:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixing bug with pureFunction clear

Browse Source
This commit is contained in:
Ken
2019-02-26 14:22:03 -08:00
parent 540e7fb638
commit ad065d4b4a
9 changed files with 26 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
step2-05/demo/src/reducers/pureFunctions.ts
View File

@@ -1,29 +1,36 @@
import { Store, FilterTypes } from '../store'; import { Store } from '../store';
export function addTodo(state: Store['todos'], id: string, label: string): Store['todos'] { export function addTodo(state: Store['todos'], id: string, label: string): Store['todos'] {
return { ...state, [id]: { label, completed: false } }; return { ...state, [id]: { label, completed: false } };
} }
export function remove(state: Store['todos'], id: string) { export function remove(state: Store['todos'], id: string) {
// Clone the Todos
const newTodos = { ...state }; const newTodos = { ...state };
// Delete an item in the object by the key
delete newTodos[id]; delete newTodos[id];
return newTodos; return newTodos;
} }
export function complete(state: Store['todos'], id: string) { export function complete(state: Store['todos'], id: string) {
// Clone the todos
const newTodos = { ...state }; const newTodos = { ...state };
// Manipulate the completed flag
newTodos[id].completed = !newTodos[id].completed; newTodos[id].completed = !newTodos[id].completed;
return newTodos; return newTodos;
} }
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
// Clone the todos
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { // Delete all todos based on the completed flag, looping over the keys of the todos
if (state.todos[key].completed) { Object.keys(state).forEach(key => {
if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-06/demo/src/reducers/pureFunctions.ts
View File

@@ -22,8 +22,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-06/exercise/src/reducers/pureFunctions.ts
View File

@@ -22,8 +22,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-07/demo/src/reducers/pureFunctions.ts
View File

@@ -22,8 +22,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-07/exercise/src/reducers/pureFunctions.ts
View File

@@ -22,8 +22,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-08/demo/src/reducers/pureFunctions.ts
View File

@@ -22,8 +22,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-08/exercise/src/reducers/pureFunctions.ts
View File

@@ -34,8 +34,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-09/demo/src/reducers/pureFunctions.ts
View File

@@ -26,8 +26,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });

4
step2-09/exercise/src/reducers/pureFunctions.ts
View File

@@ -26,8 +26,8 @@ export function complete(state: Store['todos'], id: string) {
export function clear(state: Store['todos']) { export function clear(state: Store['todos']) {
const newTodos = { ...state }; const newTodos = { ...state };
Object.keys(state.todos).forEach(key => { Object.keys(state).forEach(key => {
if (state.todos[key].completed) { if (state[key].completed) {
delete newTodos[key]; delete newTodos[key];
} }
}); });