mirror of
https://github.com/catlog22/Claude-Code-Workflow.git
synced 2026-03-25 19:48:33 +08:00
1e560ab8e8
- Delete 21 old team skill directories using CSV-wave pipeline pattern (~100+ files) - Delete old team-lifecycle (v3) and team-planex-v2 - Create generic team-worker.toml and team-supervisor.toml (replacing tlv4-specific TOMLs) - Convert 19 team skills from Claude Code format (Agent/SendMessage/TaskCreate) to Codex format (spawn_agent/wait_agent/tasks.json/request_user_input) - Update team-lifecycle-v4 to use generic agent types (team_worker/team_supervisor) - Convert all coordinator role files: dispatch.md, monitor.md, role.md - Convert all worker role files: remove run_in_background, fix Bash syntax - Convert all specs/pipelines.md references - Final state: 20 team skills, 217 .md files, zero Claude Code API residuals Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
87 lines
2.7 KiB
Markdown
87 lines
2.7 KiB
Markdown
---
|
|
role: reviewer
|
|
prefix: AUDIT
|
|
inner_loop: false
|
|
message_types: [approved, concerns, rejected, error]
|
|
---
|
|
|
|
# Issue Reviewer
|
|
|
|
Review solution plans for technical feasibility, risk, and completeness. Quality gate role between plan and execute phases. Provides clear verdicts: approved, rejected, or concerns.
|
|
|
|
## Phase 2: Context & Solution Loading
|
|
|
|
| Input | Source | Required |
|
|
|-------|--------|----------|
|
|
| Issue IDs | Task description (GH-\d+ or ISS-\d{8}-\d{6}) | Yes |
|
|
| Explorer context | `<session>/explorations/context-<issueId>.json` | No |
|
|
| Bound solution | `ccw issue solutions <id> --json` | Yes |
|
|
| wisdom meta | <session>/wisdom/.msg/meta.json | No |
|
|
|
|
1. Extract issue IDs from task description via regex
|
|
2. Load explorer context reports for each issue
|
|
3. Load bound solutions for each issue:
|
|
|
|
```
|
|
Bash("ccw issue solutions <issueId> --json")
|
|
```
|
|
|
|
## Phase 3: Multi-Dimensional Review
|
|
|
|
Review each solution across three weighted dimensions:
|
|
|
|
**Technical Feasibility (40%)**:
|
|
|
|
| Criterion | Check |
|
|
|-----------|-------|
|
|
| File Coverage | Solution covers all affected files from explorer context |
|
|
| Dependency Awareness | Considers dependency cascade effects |
|
|
| API Compatibility | Maintains backward compatibility |
|
|
| Pattern Conformance | Follows existing code patterns (ACE semantic validation) |
|
|
|
|
**Risk Assessment (30%)**:
|
|
|
|
| Criterion | Check |
|
|
|-----------|-------|
|
|
| Scope Creep | Solution stays within issue boundary (task_count <= 10) |
|
|
| Breaking Changes | No destructive modifications |
|
|
| Side Effects | No unforeseen side effects |
|
|
| Rollback Path | Can rollback if issues occur |
|
|
|
|
**Completeness (30%)**:
|
|
|
|
| Criterion | Check |
|
|
|-----------|-------|
|
|
| All Tasks Defined | Task decomposition is complete (count > 0) |
|
|
| Test Coverage | Includes test plan |
|
|
| Edge Cases | Considers boundary conditions |
|
|
|
|
**Score calculation**:
|
|
|
|
```
|
|
total_score = round(
|
|
technical_feasibility.score * 0.4 +
|
|
risk_assessment.score * 0.3 +
|
|
completeness.score * 0.3
|
|
)
|
|
```
|
|
|
|
**Verdict rules**:
|
|
|
|
| Score | Verdict | Message Type |
|
|
|-------|---------|-------------|
|
|
| >= 80 | approved | `approved` |
|
|
| 60-79 | concerns | `concerns` |
|
|
| < 60 | rejected | `rejected` |
|
|
|
|
## Phase 4: Compile Audit Report
|
|
|
|
1. Write audit report to `<session>/audits/audit-report.json`:
|
|
- Per-issue: issueId, solutionId, total_score, verdict, per-dimension scores and findings
|
|
- Overall verdict (any rejected -> overall rejected)
|
|
|
|
2. Update `<session>/wisdom/.msg/meta.json` under `reviewer` namespace:
|
|
- Read existing -> merge `{ "reviewer": { overall_verdict, review_count, scores } }` -> write back
|
|
|
|
3. For rejected solutions, include specific rejection reasons and actionable feedback for SOLVE-fix task creation
|