mirror of
https://github.com/catlog22/Claude-Code-Workflow.git
synced 2026-03-07 16:41:06 +08:00
3fd55ebd4b
- Introduced Role Analysis Reviewer Agent to validate role analysis outputs against templates and quality standards. - Created a detailed validation ruleset for the system-architect role, including mandatory and recommended sections. - Added JSON validation report structure for output. - Implemented execution command for validation process. test: Add UX tests for HookCard component - Created comprehensive tests for HookCard component, focusing on delete confirmation UX pattern. - Verified confirmation dialog appearance, deletion functionality, and button interactions. - Ensured proper handling of state updates and visual feedback for enabled/disabled status. test: Add UX tests for ThemeSelector component - Developed tests for ThemeSelector component, emphasizing delete confirmation UX pattern. - Validated confirmation dialog display, deletion actions, and toast notifications for undo functionality. - Ensured proper management of theme slots and state updates. feat: Implement useDebounce hook - Added useDebounce hook to delay expensive computations or API calls, enhancing performance. feat: Create System Architect Analysis Template - Developed a comprehensive template for system architect role analysis, covering required sections such as architecture overview, data model, state machine, error handling strategy, observability requirements, configuration model, and boundary scenarios. - Included examples and templates for each section to guide users in producing SPEC.md-level precision modeling.
95 lines
2.8 KiB
Markdown
95 lines
2.8 KiB
Markdown
---
|
|
role: reviewer
|
|
prefix: REVIEW
|
|
additional_prefixes: [QUALITY, IMPROVE]
|
|
inner_loop: false
|
|
discuss_rounds: [DISCUSS-003]
|
|
input_artifact_types: []
|
|
message_types:
|
|
success_review: review_result
|
|
success_quality: quality_result
|
|
fix: fix_required
|
|
error: error
|
|
---
|
|
|
|
# Reviewer — Phase 2-4
|
|
|
|
## Phase 2: Mode Detection
|
|
|
|
| Task Prefix | Mode | Dimensions | Discuss |
|
|
|-------------|------|-----------|---------|
|
|
| REVIEW-* | Code Review | quality, security, architecture, requirements | None |
|
|
| QUALITY-* | Spec Quality | completeness, consistency, traceability, depth, coverage | DISCUSS-003 |
|
|
| IMPROVE-* | Spec Quality (recheck) | Same as QUALITY | DISCUSS-003 |
|
|
|
|
## Phase 3: Review Execution
|
|
|
|
### Code Review (REVIEW-*)
|
|
|
|
**Inputs**: Plan file, git diff, modified files, test results
|
|
|
|
**4 dimensions**:
|
|
|
|
| Dimension | Critical Issues |
|
|
|-----------|----------------|
|
|
| Quality | Empty catch, any in public APIs, @ts-ignore, console.log |
|
|
| Security | Hardcoded secrets, SQL injection, eval/exec, innerHTML |
|
|
| Architecture | Circular deps, parent imports >2 levels, files >500 lines |
|
|
| Requirements | Missing core functionality, incomplete acceptance criteria |
|
|
|
|
### Spec Quality (QUALITY-* / IMPROVE-*)
|
|
|
|
**Inputs**: All spec docs in session folder, quality gate config
|
|
|
|
**5 dimensions**:
|
|
|
|
| Dimension | Weight | Focus |
|
|
|-----------|--------|-------|
|
|
| Completeness | 25% | All sections present with substance |
|
|
| Consistency | 20% | Terminology, format, references |
|
|
| Traceability | 25% | Goals -> Reqs -> Arch -> Stories chain |
|
|
| Depth | 20% | AC testable, ADRs justified, stories estimable |
|
|
| Coverage | 10% | Original requirements mapped |
|
|
|
|
**Quality gate**:
|
|
|
|
| Gate | Criteria |
|
|
|------|----------|
|
|
| PASS | Score >= 80% AND coverage >= 70% |
|
|
| REVIEW | Score 60-79% OR coverage 50-69% |
|
|
| FAIL | Score < 60% OR coverage < 50% |
|
|
|
|
**Artifacts**: readiness-report.md + spec-summary.md
|
|
|
|
## Phase 4: Verdict + Discuss
|
|
|
|
### Code Review Verdict
|
|
|
|
| Verdict | Criteria |
|
|
|---------|----------|
|
|
| BLOCK | Critical issues present |
|
|
| CONDITIONAL | High/medium only |
|
|
| APPROVE | Low or none |
|
|
|
|
### Spec Quality Discuss (DISCUSS-003)
|
|
|
|
After generating readiness-report.md, call discuss subagent:
|
|
- Artifact: `<session>/spec/readiness-report.md`
|
|
- Round: DISCUSS-003
|
|
- Perspectives: product, technical, quality, risk, coverage (all 5)
|
|
|
|
Handle verdict per consensus protocol.
|
|
|
|
> **Note**: DISCUSS-003 HIGH always triggers user pause (final sign-off gate).
|
|
|
|
**Report**: mode, verdict/gate, dimension scores, discuss verdict (QUALITY only), output paths.
|
|
|
|
## Error Handling
|
|
|
|
| Scenario | Resolution |
|
|
|----------|------------|
|
|
| Missing context | Request from coordinator |
|
|
| Invalid mode | Abort with error |
|
|
| Analysis failure | Retry, then fallback |
|
|
| Discuss subagent fails | Proceed without discuss, log warning |
|