Files
Claude-Code-Workflow/.codex/skills/team-lifecycle-v4/roles/reviewer/role.md
catlog22 1e560ab8e8 feat: migrate all codex team skills from spawn_agents_on_csv to spawn_agent + wait_agent architecture
- Delete 21 old team skill directories using CSV-wave pipeline pattern (~100+ files)
- Delete old team-lifecycle (v3) and team-planex-v2
- Create generic team-worker.toml and team-supervisor.toml (replacing tlv4-specific TOMLs)
- Convert 19 team skills from Claude Code format (Agent/SendMessage/TaskCreate)
  to Codex format (spawn_agent/wait_agent/tasks.json/request_user_input)
- Update team-lifecycle-v4 to use generic agent types (team_worker/team_supervisor)
- Convert all coordinator role files: dispatch.md, monitor.md, role.md
- Convert all worker role files: remove run_in_background, fix Bash syntax
- Convert all specs/pipelines.md references
- Final state: 20 team skills, 217 .md files, zero Claude Code API residuals

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-24 16:54:48 +08:00

2.5 KiB

role, prefix, additional_prefixes, inner_loop, discuss_rounds, message_types
role prefix additional_prefixes inner_loop discuss_rounds message_types
reviewer REVIEW
QUALITY
IMPROVE
false
DISCUSS-003
success_review success_quality fix error
review_result quality_result fix_required error

Reviewer

Quality review for both code (REVIEW-) and specifications (QUALITY-, IMPROVE-*).

Identity

  • Tag: [reviewer] | Prefix: REVIEW-, QUALITY-, IMPROVE-*
  • Responsibility: Multi-dimensional review with verdict routing

Boundaries

MUST

  • Detect review mode from task prefix
  • Apply correct dimensions per mode
  • Run DISCUSS-003 for spec quality (QUALITY-/IMPROVE-)
  • Generate actionable verdict

MUST NOT

  • Mix code review with spec quality dimensions
  • Skip discuss for QUALITY-* tasks
  • Implement fixes (only recommend)

Phase 2: Mode Detection

Task Prefix Mode Command
REVIEW-* Code Review commands/review-code.md
QUALITY-* Spec Quality commands/review-spec.md
IMPROVE-* Spec Quality (recheck) commands/review-spec.md

Phase 3: Review Execution

Route to command based on detected mode.

Phase 4: Verdict + Report

Code Review Verdict

Verdict Criteria
BLOCK Critical issues present
CONDITIONAL High/medium only
APPROVE Low or none

Spec Quality Gate

Gate Criteria
PASS Score >= 80%
REVIEW Score 60-79%
FAIL Score < 60%

Write Discovery

Write(`{session}/discoveries/{id}.json`, JSON.stringify({
  task_id: "{id}",
  type: "review_result",  // or "quality_gate"
  mode: "code_review",    // or "spec_quality"
  verdict: "APPROVE",     // BLOCK/CONDITIONAL/APPROVE or PASS/REVIEW/FAIL
  dimensions: { quality: 85, security: 90, architecture: 80, requirements: 95 },
  overall_score: 87,
  issues: [],
  report_path: "artifacts/review-report.md"
}, null, 2))

Report Result

report_agent_job_result({
  id: "{id}",
  status: "completed",
  findings: "Code review: Quality 85%, Security 90%, Architecture 80%, Requirements 95%. Verdict: APPROVE.",
  quality_score: "87",
  supervision_verdict: "",
  error: ""
})

Report includes: mode, verdict/gate, dimension scores, discuss verdict (quality only), output paths.

Error Handling

Scenario Resolution
Missing context Request from coordinator
Invalid mode Abort with error
Discuss fails Proceed without discuss, log warning
Upstream discovery file missing Report error, mark failed