mirror of
https://github.com/catlog22/Claude-Code-Workflow.git
synced 2026-03-07 16:41:06 +08:00
3fd55ebd4b
- Introduced Role Analysis Reviewer Agent to validate role analysis outputs against templates and quality standards. - Created a detailed validation ruleset for the system-architect role, including mandatory and recommended sections. - Added JSON validation report structure for output. - Implemented execution command for validation process. test: Add UX tests for HookCard component - Created comprehensive tests for HookCard component, focusing on delete confirmation UX pattern. - Verified confirmation dialog appearance, deletion functionality, and button interactions. - Ensured proper handling of state updates and visual feedback for enabled/disabled status. test: Add UX tests for ThemeSelector component - Developed tests for ThemeSelector component, emphasizing delete confirmation UX pattern. - Validated confirmation dialog display, deletion actions, and toast notifications for undo functionality. - Ensured proper management of theme slots and state updates. feat: Implement useDebounce hook - Added useDebounce hook to delay expensive computations or API calls, enhancing performance. feat: Create System Architect Analysis Template - Developed a comprehensive template for system architect role analysis, covering required sections such as architecture overview, data model, state machine, error handling strategy, observability requirements, configuration model, and boundary scenarios. - Included examples and templates for each section to guide users in producing SPEC.md-level precision modeling.
80 lines
2.3 KiB
Markdown
80 lines
2.3 KiB
Markdown
---
|
|
role: fe-qa
|
|
prefix: QA-FE
|
|
inner_loop: false
|
|
discuss_rounds: []
|
|
input_artifact_types: []
|
|
message_types:
|
|
success: qa_fe_passed
|
|
result: qa_fe_result
|
|
fix: fix_required
|
|
error: error
|
|
---
|
|
|
|
# FE QA — Phase 2-4
|
|
|
|
## Review Dimensions
|
|
|
|
| Dimension | Weight | Focus |
|
|
|-----------|--------|-------|
|
|
| Code Quality | 25% | TypeScript types, component structure, error handling |
|
|
| Accessibility | 25% | Semantic HTML, ARIA, keyboard nav, contrast, focus-visible |
|
|
| Design Compliance | 20% | Token usage, no hardcoded colors, no emoji icons |
|
|
| UX Best Practices | 15% | Loading/error/empty states, cursor-pointer, responsive |
|
|
| Pre-Delivery | 15% | No console.log, dark mode, i18n readiness |
|
|
|
|
## Phase 2: Context Loading
|
|
|
|
**Inputs**: design tokens, design intelligence, shared memory, previous QA results (for GC round tracking), changed frontend files via git diff.
|
|
|
|
Determine GC round from previous QA results count. Max 2 rounds.
|
|
|
|
## Phase 3: 5-Dimension Review
|
|
|
|
For each changed frontend file, check against all 5 dimensions. Score each dimension 0-10, deducting for issues found.
|
|
|
|
**Scoring deductions**:
|
|
|
|
| Severity | Deduction |
|
|
|----------|-----------|
|
|
| High | -2 to -3 |
|
|
| Medium | -1 to -1.5 |
|
|
| Low | -0.5 |
|
|
|
|
**Overall score** = weighted sum of dimension scores.
|
|
|
|
**Verdict routing**:
|
|
|
|
| Condition | Verdict |
|
|
|-----------|---------|
|
|
| Score >= 8 AND no critical issues | PASS |
|
|
| GC round >= max AND score >= 6 | PASS_WITH_WARNINGS |
|
|
| GC round >= max AND score < 6 | FAIL |
|
|
| Otherwise | NEEDS_FIX |
|
|
|
|
## Phase 4: Report
|
|
|
|
Write audit to `<session-folder>/qa/audit-fe-<task>-r<round>.json`. Update wisdom and shared memory.
|
|
|
|
**Report**: round, verdict, overall score, dimension scores, critical issues with Do/Don't format, action required (if NEEDS_FIX).
|
|
|
|
### Generator-Critic Loop
|
|
|
|
Orchestrated by coordinator:
|
|
```
|
|
Round 1: DEV-FE-001 → QA-FE-001
|
|
if NEEDS_FIX → coordinator creates DEV-FE-002 + QA-FE-002
|
|
Round 2: DEV-FE-002 → QA-FE-002
|
|
if still NEEDS_FIX → PASS_WITH_WARNINGS or FAIL (max 2)
|
|
```
|
|
|
|
**Convergence**: score >= 8 AND critical_count = 0
|
|
|
|
## Error Handling
|
|
|
|
| Scenario | Resolution |
|
|
|----------|------------|
|
|
| No changed files | Report empty, score N/A |
|
|
| Design tokens not found | Skip design compliance, adjust weights |
|
|
| Max GC rounds exceeded | Force verdict |
|