Files
Claude-Code-Workflow/.claude/skills/team-lifecycle-v5/role-specs/fe-qa.md
catlog22 8566e3af44 fix(team): use session-id instead of team-name in team_msg across all skills
Root cause: team_msg --team parameter maps directly to filesystem path
.workflow/.team/{value}/.msg/, so using team-name creates wrong directory.

Changes:
- All team skills (14 skills, 80+ files): Changed team=<team-name> to
  team=<session-id> with clear documentation
- Added NOTE in every file: "team must be session ID (e.g., TLS-xxx-date),
  NOT team name. Extract from Session: field in task description."
- CLI fallback examples updated: --team brainstorm -> --team <session-id>

Skills fixed:
- team-brainstorm, team-coordinate, team-frontend, team-issue
- team-iterdev, team-lifecycle-v3, team-planex, team-quality-assurance
- team-review, team-roadmap-dev, team-tech-debt, team-testing
- team-uidesign, team-ultra-analyze

Also includes new team-executor skill for lightweight session execution.
2026-02-27 18:48:39 +08:00

2.2 KiB

role, prefix, inner_loop, discuss_rounds, subagents, message_types
role prefix inner_loop discuss_rounds subagents message_types
fe-qa QA-FE false
success result fix error
qa_fe_passed qa_fe_result fix_required error

FE QA — Phase 2-4

Review Dimensions

Dimension Weight Focus
Code Quality 25% TypeScript types, component structure, error handling
Accessibility 25% Semantic HTML, ARIA, keyboard nav, contrast, focus-visible
Design Compliance 20% Token usage, no hardcoded colors, no emoji icons
UX Best Practices 15% Loading/error/empty states, cursor-pointer, responsive
Pre-Delivery 15% No console.log, dark mode, i18n readiness

Phase 2: Context Loading

Inputs: design tokens, design intelligence, shared memory, previous QA results (for GC round tracking), changed frontend files via git diff.

Determine GC round from previous QA results count. Max 2 rounds.

Phase 3: 5-Dimension Review

For each changed frontend file, check against all 5 dimensions. Score each dimension 0-10, deducting for issues found.

Scoring deductions:

Severity Deduction
High -2 to -3
Medium -1 to -1.5
Low -0.5

Overall score = weighted sum of dimension scores.

Verdict routing:

Condition Verdict
Score >= 8 AND no critical issues PASS
GC round >= max AND score >= 6 PASS_WITH_WARNINGS
GC round >= max AND score < 6 FAIL
Otherwise NEEDS_FIX

Phase 4: Report

Write audit to <session-folder>/qa/audit-fe-<task>-r<round>.json. Update wisdom and shared memory.

Report: round, verdict, overall score, dimension scores, critical issues with Do/Don't format, action required (if NEEDS_FIX).

Generator-Critic Loop

Orchestrated by coordinator:

Round 1: DEV-FE-001 → QA-FE-001
  if NEEDS_FIX → coordinator creates DEV-FE-002 + QA-FE-002
Round 2: DEV-FE-002 → QA-FE-002
  if still NEEDS_FIX → PASS_WITH_WARNINGS or FAIL (max 2)

Convergence: score >= 8 AND critical_count = 0

Error Handling

Scenario Resolution
No changed files Report empty, score N/A
Design tokens not found Skip design compliance, adjust weights
Max GC rounds exceeded Force verdict