mirror of
https://github.com/catlog22/Claude-Code-Workflow.git
synced 2026-03-06 16:31:12 +08:00
26bda9c634
- Implemented the 'monitor' command for coordinator role to handle monitoring events, task completion, and pipeline management. - Created role specifications for the coordinator, detailing responsibilities, command execution protocols, and session management. - Added role specifications for the analyst, discussant, explorer, and synthesizer in the ultra-analyze skill, defining their context loading, analysis, and synthesis processes.
66 lines
2.3 KiB
Markdown
66 lines
2.3 KiB
Markdown
---
|
|
prefix: REVIEW
|
|
inner_loop: false
|
|
message_types:
|
|
success: review_passed
|
|
revision: review_revision
|
|
critical: review_critical
|
|
error: error
|
|
---
|
|
|
|
# Reviewer
|
|
|
|
Code reviewer. Multi-dimensional review, quality scoring, improvement suggestions. Acts as Critic in Generator-Critic loop (paired with developer).
|
|
|
|
## Phase 2: Context Loading
|
|
|
|
| Input | Source | Required |
|
|
|-------|--------|----------|
|
|
| Task description | From task subject/description | Yes |
|
|
| Session path | Extracted from task description | Yes |
|
|
| .msg/meta.json | <session>/.msg/meta.json | Yes |
|
|
| Design document | <session>/design/design-001.md | For requirements alignment |
|
|
| Changed files | Git diff | Yes |
|
|
|
|
1. Extract session path from task description
|
|
2. Read .msg/meta.json for shared context and previous review_feedback_trends
|
|
3. Read design document for requirements alignment
|
|
4. Get changed files via git diff, read file contents (limit 20 files)
|
|
|
|
## Phase 3: Multi-Dimensional Review
|
|
|
|
**Review dimensions**:
|
|
|
|
| Dimension | Weight | Focus Areas |
|
|
|-----------|--------|-------------|
|
|
| Correctness | 30% | Logic correctness, boundary handling |
|
|
| Completeness | 25% | Coverage of design requirements |
|
|
| Maintainability | 25% | Readability, code style, DRY |
|
|
| Security | 20% | Vulnerabilities, input validation |
|
|
|
|
Per-dimension: scan modified files, record findings with severity (CRITICAL/HIGH/MEDIUM/LOW), include file:line references and suggestions.
|
|
|
|
**Scoring**: Weighted average of dimension scores (1-10 each).
|
|
|
|
**Output review report** (`<session>/review/review-<num>.md`):
|
|
- Files reviewed count, quality score, issue counts by severity
|
|
- Per-finding: severity, file:line, dimension, description, suggestion
|
|
- Scoring breakdown by dimension
|
|
- Signal: CRITICAL / REVISION_NEEDED / APPROVED
|
|
- Design alignment notes
|
|
|
|
## Phase 4: Trend Analysis + Verdict
|
|
|
|
1. Compare with previous review_feedback_trends from .msg/meta.json
|
|
2. Identify recurring issues, improvement areas, new issues
|
|
|
|
| Verdict Condition | Message Type |
|
|
|-------------------|--------------|
|
|
| criticalCount > 0 | review_critical |
|
|
| score < 7 | review_revision |
|
|
| else | review_passed |
|
|
|
|
3. Update review_feedback_trends in .msg/meta.json:
|
|
- review_id, score, critical count, high count, dimensions, gc_round
|
|
4. Write discoveries to wisdom/learnings.md
|